After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639950 - flacparse: avoid unref'ing NULL buffer
flacparse: avoid unref'ing NULL buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal critical
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-19 14:28 UTC by Mark Nauwelaerts
Modified: 2011-01-19 18:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
flacparse: mind gst_buffer_unref not liking NULL (1.39 KB, patch)
2011-01-19 14:28 UTC, Mark Nauwelaerts 		none Details | Review
flacparse: mind gst_buffer_unref not liking NULL (1.87 KB, patch)
2011-01-19 17:28 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2011-01-19 14:28:47 UTC 
Created attachment 178726 [details] [review]
flacparse: mind gst_buffer_unref not liking NULL

Attached patch removes entries from a collected list altogether rather than leaving a NULL buffer entry lying around that will trip gst_buffer_unref later on.
Comment 1 Tim-Philipp Müller 2011-01-19 17:17:41 UTC 
Right, I guess that happens in the return FALSE case.

However, it also doesn't seem entirely right to me to keep around a partial header set/list in that case. The header buffers all belong together, so should either all be freed or all be kept IMHO.
Comment 2 Mark Nauwelaerts 2011-01-19 17:28:06 UTC 
Created attachment 178756 [details] [review]
flacparse: mind gst_buffer_unref not liking NULL

Alternative approach as suggested.
Comment 3 Mark Nauwelaerts 2011-01-19 18:01:59 UTC 
commit 289cd65abd5429ed2230b69cc1f009ce692a5411
Author: Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk>
Date:   Wed Jan 19 18:26:30 2011 +0100

    flacparse: mind gst_buffer_unref not liking NULL
    
    Fixes #639950.