After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639947 - Strange characters when selecting playlists to sync to MP3 player
Strange characters when selecting playlists to sync to MP3 player
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - USB Mass Storage
2.0.0
Other Linux
: Normal normal
: ---
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-19 14:02 UTC by Jonathan Lumb
Modified: 2012-12-16 21:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Second screenshot (12.10 KB, image/png)
2011-01-19 14:02 UTC, Jonathan Lumb
  Details
First screenshot (226.43 KB, image/png)
2011-01-19 14:03 UTC, Jonathan Lumb
  Details
screen grab of the problem (180.95 KB, image/png)
2011-04-15 08:39 UTC, Jonathan Lumb
  Details
question marks and quotes mixed (124.46 KB, image/png)
2012-06-05 13:44 UTC, Dmitry Suzdalev
  Details
Proposed patch (1.20 KB, patch)
2012-12-16 16:17 UTC, Andrés G. Aragoneses (IRC: knocte)
committed Details | Review

Description Jonathan Lumb 2011-01-19 14:02:10 UTC
When trying to sync music to my Sansa Clip Plus MP3 player, the menu for choosing playlists available for syncing contains many ??? characters on either side of playlist names:

??? Sansa ???
??? Playlist1 ???
??? Playlist2 ???

Furthermore, once music has been synced to the device, there are more strange characters in the playlists listed below the MP3 player in the left-hand navigation bar.

I have attached screenshots as it saves me explaining.

Please let me know if I can provide any more information to help.

Thanks
Comment 1 Jonathan Lumb 2011-01-19 14:02:38 UTC
Created attachment 178723 [details]
Second screenshot
Comment 2 Jonathan Lumb 2011-01-19 14:03:33 UTC
Created attachment 178724 [details]
First screenshot
Comment 3 Alexander Kojevnikov 2011-02-02 11:31:52 UTC
Which version and distro are you using? Could you try to compile Banshee yourself?

This looks like bug 608243 that was fixed a year ago.
Comment 4 Jonathan Lumb 2011-02-02 11:57:52 UTC
Linux jonoxps 2.6.35-22-generic #35-Ubuntu SMP Sat Oct 16 20:36:48 UTC 2010 i686 GNU/Linux

I'm using Ubuntu 10.04 with Banshee version 1.9.2 fresh from the PPA.

This must be another bug?
Comment 5 Fabio Durán Verdugo 2011-04-15 01:44:05 UTC
can you test with a banshee version >=1.95 ?
Comment 6 Jonathan Lumb 2011-04-15 08:38:30 UTC
Tested in Banshee 2.0 in Ubuntu 11.04 (Beta 2)

The problem is still present, screenshot attached.
Comment 7 Jonathan Lumb 2011-04-15 08:39:09 UTC
Created attachment 186003 [details]
screen grab of the problem
Comment 8 Gabriel Burt 2011-04-15 20:26:55 UTC
I really don't think this is our problem.  My guess is Debian or Ubuntu's packaging system/process is messing up our source code, not treating it as UTF-8.  Please file on Launchpad.
Comment 9 Jonathan Lumb 2011-04-15 20:43:33 UTC
It seems that this was already reported on Launchpad back in 2010 but nobody has yet dealt with the bug. I have added extra information and screenshots and hopefully somebody can look into this soon.

https://bugs.launchpad.net/banshee/+bug/685119
Comment 10 Chow Loong Jin 2011-04-16 01:58:39 UTC
Regarding this, the issue is that mono doesn't consider source code to be UTF-8 unless your locale is set to UTF-8. Meaning that those who don't use a UTF-8 locale while building Banshee will see this bug.

I think this can be resolved by passing -codepage:utf8 into the build.
Comment 11 Gabriel Burt 2011-04-16 02:13:07 UTC
Oh really?!  Sounds like a bug in Mono, and also something we can work around in Banshee by passing that argument.
Comment 12 Gabriel Burt 2011-04-16 02:17:22 UTC
Why isn't the locale set to utf-8 on the ubuntu builds, though?
Comment 13 Chow Loong Jin 2011-04-16 02:22:28 UTC
It's set to C for the sake of a pristine environment, if I'm not mistaken.
Comment 14 Dmitry Suzdalev 2012-06-05 13:41:12 UTC
I'm seeing this in Arch Linux, using Banshee 2.4.1 (all previous versions had this bug too).

What I'd like to add is that I am not sure that this is an issue related to how banshee is built, because I'm 100% sure that I get these question marks only occasionally :)

That is - one time I try to sync my player - and ??? are there, and next day those are pretty " symbols. The other day - again ???. So this seems to be dependent on something in runtime...

Also I noticed that banshee keeps forgetting my selection for this combobox and always has 'Manage Manually' there. Could it be because of these changing quotes? Aka it remembers one string and then it doesn't match, so things are reset to defaults...
Comment 15 Dmitry Suzdalev 2012-06-05 13:44:44 UTC
Created attachment 215641 [details]
question marks and quotes mixed

Oh, by the way, as an addition to my previous comment, check out this screenshot I just done. It has question marks and quotes mixed! :)
Comment 16 Jonathan Lumb 2012-06-05 14:17:13 UTC
I can confirm what Dmitry says - there have been times when there were no question marks in the drop-down list. Furthermore, sometimes I have to re-select the playlist to be synced as Banshee forgets the previous value - perhaps suggesting a string mismatch.
Comment 17 Andrés G. Aragoneses (IRC: knocte) 2012-12-16 16:17:53 UTC
Created attachment 231657 [details] [review]
Proposed patch

Screenshot posted in comment 1 makes me think this is related to bug 647917, which was fixed a year ago (about some months after this bug was reported).

Dmitry on the other hand says he reproduces this with Banshee 2.4.1, which was released this year; however, he seems to refer to the problem that screenshot posted in comment 2 highlights, which seems to be a bit different (although very related as well, i.e.: one problem could be the cause of the other).

The latter, in theory, was fixed in bug 608243 as Alex points out. However, I just found out that the change for fixing this bug missed one occurrence of the harmful string, therefore I'm posting a patch to fix the last occurrence. (This also explains why some commenters in this bug asserted that they were getting this behaviour only "sometimes".)
Comment 18 Andrés G. Aragoneses (IRC: knocte) 2012-12-16 21:44:52 UTC
Comment on attachment 231657 [details] [review]
Proposed patch

http://git.gnome.org/browse/banshee/commit/?id=2c697a209790ae241d1f44cccf2bb10ea91135cc
Comment 19 Andrés G. Aragoneses (IRC: knocte) 2012-12-16 21:45:33 UTC
This problem has been fixed in the development version. The fix will be available in the next software release. Thank you for your bug report.