After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639929 - State attribute on GdkEventKey is missing GdkModifierType annotation (it has C type guint)
State attribute on GdkEventKey is missing GdkModifierType annotation (it has ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2011-01-19 10:06 UTC by Laszlo Pandy
Modified: 2011-01-20 10:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add annotation (type GdkModifierType) to state attributes in many GdkEvent structs. (4.15 KB, patch)
2011-01-19 10:08 UTC, Laszlo Pandy 		accepted-commit_now Details | Review

Description Laszlo Pandy 2011-01-19 10:06:10 UTC 
The state attribute in GdkEventKey cannot be properly wrapped in the GI PyGObject bindings because the flag type annotation (GdkModifierType) is missing. This annotation is also missing in other event types which also have a state attribute such as GdkEventMotion, GdkEventButton, GdkEventScroll, GdkEventCrossing.
Comment 1 Laszlo Pandy 2011-01-19 10:08:09 UTC 
Created attachment 178700 [details] [review]
Add annotation (type GdkModifierType) to state attributes in many GdkEvent structs.

The state attribute is available in GdkEventMotion, GdkEventButton, GdkEventScroll, GdkEventKey and GdkEventCrossing. This type annotation fixes the wrapping of this attribute in the GI PyGObject bindings.
Comment 2 Martin Pitt 2011-01-20 10:18:26 UTC 
Comment on attachment 178700 [details] [review]
Add annotation (type GdkModifierType) to state attributes in many GdkEvent structs.

Can you please fix the line breaking of the commit log? Otherwise this looks good, thanks! Please push.