After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639831 - Add shared-library to cairo-1.0.gir
Add shared-library to cairo-1.0.gir
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2011-01-18 10:24 UTC by Tomeu Vizoso
Modified: 2015-02-07 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Add shared-library to cairo-1.0.gir (882 bytes, patch)
2011-01-18 10:24 UTC, Tomeu Vizoso 		reviewed Details | Review
Depend on cairo-gobject if available (2.89 KB, patch)
2011-01-19 11:44 UTC, Tomeu Vizoso 		none Details | Review
Depend on cairo-gobject if available (2.84 KB, patch)
2011-01-19 11:47 UTC, Tomeu Vizoso 		committed Details | Review

Description Tomeu Vizoso 2011-01-18 10:24:48 UTC 
So bindings don't need to link to libcairo-gobject.so by themselves
Comment 1 Tomeu Vizoso 2011-01-18 10:24:51 UTC 
Created attachment 178610 [details] [review]
Add shared-library to cairo-1.0.gir

So libcairo-gobject gets loaded.
Comment 2 Colin Walters 2011-01-18 16:19:08 UTC 
Review of attachment 178610 [details] [review]:

It does seem unlikely anything will be using cairo.gir without also having the ability to use cairo-gobject.

But yes conditionalizing it would be nice; move it to cairo-1.0.gir.in, then substitute in the value.
Comment 3 Tomeu Vizoso 2011-01-19 11:44:48 UTC 
Created attachment 178706 [details] [review]
Depend on cairo-gobject if available

And set library-name and package accordingly in the cairo .gir
Comment 4 Tomeu Vizoso 2011-01-19 11:47:34 UTC 
Created attachment 178707 [details] [review]
Depend on cairo-gobject if available

And set library-name and package accordingly in the cairo .gir
Comment 5 Pavel Holejsovsky 2011-01-20 14:52:46 UTC 
Review of attachment 178707 [details] [review]:

I have not much experience with autoconf, but the patch looks fine to me.
Comment 6 Johan (not receiving bugmail) Dahlin 2011-01-20 15:18:57 UTC 
Review of attachment 178707 [details] [review]:

It's bit weird that the cairo gir represents different things depending on if cairo. But I can't find of any better solutions, and GIRs are already pretty
much tied to the system they are generated on.
Comment 7 Tomeu Vizoso 2011-01-20 15:46:25 UTC 
Attachment 178707 [details] pushed as 934729d - Depend on cairo-gobject if available
Comment 8 André Klapper 2015-02-07 17:01:53 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]