GNOME Bugzilla – Bug 639778
discoverer: Drop new stream tags once preroll is done
Last modified: 2011-01-17 23:51:47 UTC
There can be a race between the pad event probe function and discoverer processing since the former works on taglists that the latter might also be using at the same time. I'm attaching a patch to fix this. The problem occured randomly while running on a large number of files. The actual crash always happened on a (random) FLAC file for me.
Created attachment 178553 [details] [review] discoverer: Drop new stream tags once preroll is done This makes sure we do not touch the stream taglist once the pipeline has been prerolled. Adding of stream tags happens in the pad event probe which runs in a different thread from discoverer stream processing, so modifying the tag list while discoverer might be processing it can sometimes cause a crash.
commit 6ac2e5d3846b2038113ed2dda7c298e296faa938 Author: Arun Raghavan <arun.raghavan@collabora.co.uk> Date: Tue Jan 18 01:09:53 2011 +0530 discoverer: Drop new stream tags once preroll is done This makes sure we do not touch the stream taglist once the pipeline has been prerolled. Adding of stream tags happens in the pad event probe which runs in a different thread from discoverer stream processing, so modifying the tag list while discoverer might be processing it can sometimes cause a crash. https://bugzilla.gnome.org/show_bug.cgi?id=639778