GNOME Bugzilla – Bug 639644
Banshee.Bpm needs Banshee.GStreamer which is not built on Windows
Last modified: 2011-01-18 19:43:44 UTC
Created attachment 178426 [details] [review] Add Condition attributes to backend ProjectReference elements Since libbanshee and the Banshee.GStreamer backend are not used on Windows, the Banshee.Bpm project will not build because it includes a project reference to Banshee.GStreamer. I'm not sure what the preferred method for handling this discrepancy is, but one possibility is to use a Condition attribute on the ProjectReference element. I was able to get it to build successfully by using a '$(Configuration)' == 'Windows' condition on a ProjectReference to the Banshee.GStreamerSharp project.
Review of attachment 178426 [details] [review]: I think this is ok, but really we'll need to implement a IBpmDetector for the Banshee.GStreamerSharp backend. I think we can commit this w/o adding that first -- should just silently fail when it sees the gst# backend doesn't have a bpm detector -- but can you test that it works still?
(In reply to comment #1) > Review of attachment 178426 [details] [review]: > > I think this is ok, but really we'll need to implement a IBpmDetector for the > Banshee.GStreamerSharp backend. I think we can commit this w/o adding that > first -- should just silently fail when it sees the gst# backend doesn't have a > bpm detector -- but can you test that it works still? It didn't even occur to me to check that. I would say that as long as it doesn't crash the application, it should be fine. I will check that this is the case shortly.
Nothing crashes, but the BPM Detection extension is disabled (you cannot tick the checkbox). I guess for now we could either go ahead and apply the patch to use conditional references, or just remove the project from the Windows configuration, since building it doesn't provide anything yet.
Review of attachment 178426 [details] [review]: Committed, thanks