GNOME Bugzilla – Bug 639580
Adding more debug information to dvb plugin
Last modified: 2012-06-21 09:48:13 UTC
Created attachment 178381 [details] [review] patch01 patch 1: Specify that is a ioctl error and not a user input error. patch 2: I spent an hour before figuring out which chanels.conf file dvbsrc was using and if was able to find it.
Created attachment 178382 [details] [review] patch02
*** Bug 639579 has been marked as a duplicate of this bug. ***
Review of attachment 178381 [details] [review]: gst_dvbsrc_tune() needs better error handling in general, preferably causing an element error if something goes wrong. The existing g_warning() is useless. Changing this to say which ioctl failed is rearranging deck chairs -- users don't know and/or care.
Review of attachment 178382 [details] [review]: The code already does the right thing if the channels.conf file is missing. If you want to complain that you couldn't figure out what it was looking for, that's fine, but it's a documentation issue. Please submit a documentation patch instead.
Review of attachment 178382 [details] [review]: I am complaining a usability issue. if you try to open a file and the file is not there the application should give you some feedback not just close the channel and say: ERROR: from element /GstURIDecodeBin:uridecodebin0: No URI handler implemented for "dvb".
I fixed the file issues in a slightly different way. commit 56487d38bd42c97ae11882f50e8763d70ca4c389 Author: Edward Hervey <edward.hervey@collabora.co.uk> Date: Tue Jun 19 10:35:48 2012 +0200 dvb: Detect more issues with configuration file Report useful errors when: * file is present but empty * requested channel is not present commit 1dd3544b8dba445160fdeddef98c5678744ee749 Author: Edward Hervey <edward.hervey@collabora.co.uk> Date: Tue Jun 19 10:22:50 2012 +0200 dvbbasebin: Emit an error when we fail reading the channels file