After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639501 - libs/rgbe/rgbe.c has a typo x_axis should be y_axis
libs/rgbe/rgbe.c has a typo x_axis should be y_axis
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2011-01-14 08:53 UTC by Patrick Horgan
Modified: 2011-03-28 22:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the problem. (788 bytes, patch)
2011-01-14 08:53 UTC, Patrick Horgan 		none Details | Review

Description Patrick Horgan 2011-01-14 08:53:51 UTC 
Created attachment 178300 [details] [review]
Patch to fix the problem.

I was curious about a warning:
rgbe.c: In function ‘rgbe_header_init’:
rgbe.c:149:25: warning: operation on ‘header->x_axis.size’ may be undefined [-Wsequence-point]

The line (with preceding line) was:
   header->x_axis.orient = header->y_axis.orient = ORIENT_UNKNOWN;
   header->x_axis.size   = header->x_axis.size   = 0;

It's obviously a sequence point issue, but just as obviously it should have been:

   header->x_axis.size   = header->y_axis.size   = 0;

Patch attached.
Comment 1 Jon Nordby 2011-03-28 22:18:50 UTC 
Already fixed in master. Thanks for the patch, sorry for not reviewing more promptly.