After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639493 - Port to latest gtk+3 (2.99.2)
Port to latest gtk+3 (2.99.2)
Status: RESOLVED FIXED
Product: seahorse-plugins
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: 2.24
Assigned To: seahorse-plugins-maint
seahorse-plugins-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-14 02:42 UTC by Nirbheek Chauhan
Modified: 2011-02-10 08:12 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
Port to gtk+3 (2.68 KB, patch)
2011-01-14 02:42 UTC, Nirbheek Chauhan
none Details | Review

Description Nirbheek Chauhan 2011-01-14 02:42:24 UTC
Created attachment 178293 [details] [review]
Port to gtk+3

Attached below is a patch to port the agent and seahorse-tool to the latest gtk+3.

Specifically, some methods from GtkComboBox have moved to GtkComboBoxText, gtk_quit_add has been removed, and GktFunction has been replaced by GSourceFunc.

This also bumps the min reqs of gtk+2 to 2.23.0, and gtk+3 to 2.91.7. I've tested, and it works with both.
Comment 1 Matthias Clasen 2011-01-20 19:00:47 UTC
Patch looks good to me. Stef, whats the process for getting simple build fixes into seahorse-plugins ?
Comment 2 Stef Walter 2011-02-09 17:07:39 UTC
Adam's the maintainer, but I'll try to do it. I just need to figure out how to build and distcheck seahorse-plugins with all the various magical options. The mozilla devel packages are a real confusing pain.
Comment 3 Stef Walter 2011-02-10 08:12:47 UTC
Thanks Nirbheek. Merged your patch.