After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639474 - kbd-status: Menu stays open when selecting layouts
kbd-status: Menu stays open when selecting layouts
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-13 22:41 UTC by Florian Müllner
Modified: 2011-01-14 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
kbd-status: Close the menu when switching layouts (961 bytes, patch)
2011-01-13 22:41 UTC, Florian Müllner 		none Details | Review
generic-container: Queue a redraw in skip_paint() (1.02 KB, patch)
2011-01-13 23:00 UTC, Florian Müllner 		accepted-commit_now Details | Review
kbd-status: Close the menu when switching layouts (961 bytes, patch)
2011-01-14 00:10 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-01-13 22:41:08 UTC 
See attached patch.
Comment 1 Florian Müllner 2011-01-13 22:41:13 UTC 
Created attachment 178271 [details] [review]
kbd-status: Close the menu when switching layouts

Layout items in the menu overwrite PopupBaseMenuItem.activate(),
so the menu stays open when selecting a layout from the menu.
Chain up to the parent class' method to make the items behave properly.
Comment 2 Florian Müllner 2011-01-13 23:00:31 UTC 
Created attachment 178273 [details] [review]
generic-container: Queue a redraw in skip_paint()

When changing a child's visibility with skip_paint(), the change
will not be visible until a redraw is triggered. Queue a redraw,
so that the function has an immediate effect.

(In reply to comment #2)
> Shouldn't calling _set_skip_paint call _queue_redraw() itself in
> shell-generic-container.c?

Makes sense to me.
Comment 3 Colin Walters 2011-01-13 23:49:55 UTC 
Review of attachment 178273 [details] [review]:

Looks good.
Comment 4 Florian Müllner 2011-01-14 00:10:45 UTC 
Created attachment 178277 [details] [review]
kbd-status: Close the menu when switching layouts

Layout items in the menu overwrite PopupBaseMenuItem.activate(),
so the menu stays open when selecting a layout from the menu.
Chain up to the parent class' method to make the items behave properly.

Sorry, obsoleted the wrong patch.
Comment 5 Giovanni Campagna 2011-01-14 13:01:33 UTC 
Review of attachment 178277 [details] [review]:

Looks correct.
Comment 6 Florian Müllner 2011-01-14 13:10:32 UTC 
Attachment 178277 [details] pushed as d21f04b - kbd-status: Close the menu when switching layouts