GNOME Bugzilla – Bug 639459
panelMenu: Make the appMenu unclickable when fading out.
Last modified: 2014-08-07 10:29:52 UTC
For some reason, clicking on the application menu while going into the overview caused memory corruption and then a hard crash after taking a little while.
Created attachment 178257 [details] [review] panelMenu: Make the appMenu unclickable when fading out.
Review of attachment 178257 [details] [review]: No
Created attachment 187406 [details] [review] appMenu: Disable reactivity at the start of animation If you clicked on the application button while it was fading out, like during a transition to the overview, a vestigal menu appeared.
While it seems that the memory corruption is gone (I'm going to guess that fixing atlas fixed it), the unattached menu is still wrong.
Review of attachment 187406 [details] [review]: ::: js/ui/panel.js @@ +315,3 @@ + transition: 'easeOutQuad', + onComplete: function() { + this.actor.reactive = true; I think we should make the actor reactive immediately; no reason not to be able to click on it when it's 99% opacity.
Created attachment 187749 [details] [review] appMenu: Disable reactivity at the start of animation If you clicked on the application button while it was fading out, like during a transition to the overview, a vestigal menu appeared. appMenu: Disable reactivity at the start of animation OK.
Review of attachment 187749 [details] [review]: Looks good, thanks!
Comment on attachment 187749 [details] [review] appMenu: Disable reactivity at the start of animation Attachment 187749 [details] pushed as c4f5274 - appMenu: Disable reactivity at the start of animation I can see you're extremely excited about it, too!
Patch isn't fully correct: Start on a populated desktop Enter the overview Switch to the empty desktop Leave the overview You can now get the menu for the last application by clicking on the blank space. Probably the best thing to do would be to implement the cleanup described in bug 645734 so we don't have weirdly interacting code paths for hiding the button two different ways.
I cannot reproduce: Have populated desktop Super Ctrl+Shift+Down to empty desktop Super Ctrl+Alt+Tab to top panel Hit right The date menu is selected for me.
(In reply to comment #11) > I cannot reproduce: > > Have populated desktop > Super > Ctrl+Shift+Down to empty desktop > Super > Ctrl+Alt+Tab to top panel > Hit right > > The date menu is selected for me. Does that mean this is fixed? This bug seems dead.
Let's assume bug 645734 fixed the remaining issue.
*** Bug 647458 has been marked as a duplicate of this bug. ***