GNOME Bugzilla – Bug 639427
remuxer.py: allow more than one stream of the same type
Last modified: 2011-09-26 16:59:42 UTC
Queue names would collide otherwise, so add the pad name too, which guarantees names will be unique.
Created attachment 178232 [details] [review] remuxer.py: allow more than one stream of the same type Queue names would collide otherwise, so add the pad name too, which guarantees names will be unique.
Comment on attachment 178232 [details] [review] remuxer.py: allow more than one stream of the same type I'm not convinced that queue_subtitle/x-kate_/__main__+Remuxer:__main__+remuxer0/GstBin:bin0/GstOggDemux:oggdemux1.GstOggPad:serial_67f24fc7 (__main__.GstOggPad) is a good name for an element ;-) Is there any reason not to just pass None here?
From what I recall, the issue was just duplicate generated names breaking causing a fatal error, so... passing NULL ought to be alright I suppose. Maybe I did not realize you could pass None for letting a name be selected by the lib at the time. Trying it here, I get not-negotiated errors both with and without the patch, so something broke somewhere which means I can't test with None as name, but I reckon it should be alright. I'll queue the not-negotiated fix for later... :/
Ok, pushed with None. Seems to work. commit 160b6d1bd5e251a6d66a203a519db630528f60e3 Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Thu Jan 13 14:59:16 2011 +0000 remuxer.py: allow more than one stream of the same type Queue names would collide otherwise, so just pass None for now. Also guarantees that we don't get silly names like "queue_audio/x-foobar". https://bugzilla.gnome.org/show_bug.cgi?id=639427