After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639413 - Camerabin should use output-selector:pad-negotiation-mode=active
Camerabin should use output-selector:pad-negotiation-mode=active
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal blocker
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-13 11:32 UTC by Lasse Laukkanen
Modified: 2011-01-13 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch to set pad-negotation-mode=active (1000 bytes, patch)
2011-01-13 11:54 UTC, Lasse Laukkanen
committed Details | Review

Description Lasse Laukkanen 2011-01-13 11:32:41 UTC
Latest output-selector has new pad-negotiation-mode property with default set as 'all'.

Inside camerabin output-selector src pads are linked to viewfinder, videobin and imagebin parts, and caps for these parts should be negotiated independently so that we can support different formats for each part. With pad-negotiation-mode=all we require common format for all three parts. This can be fixed by setting output-selector:pad-negotiation-mode=active in camerabin.
Comment 1 Lasse Laukkanen 2011-01-13 11:54:17 UTC
Created attachment 178212 [details] [review]
Proposed patch to set pad-negotation-mode=active
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2011-01-13 13:03:33 UTC
The property was introduced with
commit 757dc90faa163a235e1d16791a0a0f8c74715768
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Tue Jan 4 12:42:50 2011 -0300

    output-selector: Add pad-negotiation-mode property
    
    Adds getcaps/setcaps to output-selector and adds a property
    to select which type of negotiation should be done.
    
    The available modes are:
     * none:   no negotiation (current behavior), getcaps return ANY and
               setcaps aren't set on any of the peers
     * all:    use all pads (default), getcaps returns the intersection of
               peer pads and setcaps is set on all peers
     * active: getcaps and setcaps are proxied to the active pad
    
    https://bugzilla.gnome.org/show_bug.cgi?id=638381
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2011-01-13 13:06:07 UTC
commit 85a355fd84a7c50fe6d22e98c3fd122b75985e6e
Author: Teemu Katajisto <teemu.katajisto@digia.com>
Date:   Thu Jan 13 13:36:09 2011 +0200

    camerabin: set pad-negotiation-mode to active for output-selector
    
    Fixes #639413.