GNOME Bugzilla – Bug 639366
Optionally integrate valgrind into make check target
Last modified: 2011-01-16 06:36:38 UTC
It would be nice if we always had an option of running tests with valgrind. Currently some of the tests have a timeout that if it's reached it is considered a failure. The timeout period needs to be increased when running under valgrind.
Created attachment 178179 [details] [review] Added valgrind support in make check.
Review of attachment 178179 [details] [review]: Looks good apart from these two indentation problems. What about also changing the timeout code in telepathy/persona-store-capabilities.vala, telepathy/individual-properties.vala and key-file/individual-retrieval.vala? ::: tests/folks/aggregation.vala @@ +40,3 @@ + + if (Environment.get_variable ("FOLKS_TEST_VALGRIND") != null) + this.test_timeout = 10; Indentation problem. ::: tests/telepathy/individual-retrieval.vala @@ +37,3 @@ + + if (Environment.get_variable ("FOLKS_TEST_VALGRIND") != null) + this.test_timeout = 10; Indentation problem.
Created attachment 178304 [details] [review] Added valgrind support in make check. Fixes the indentation issues (I'm new to emacs vala-mode). Added the variable timeout to the other tests.
Review of attachment 178304 [details] [review]: Please feel free to push your changes once the comment below is fixed in all the relevant places (sorry, I missed this before). Thanks! ::: tests/folks/aggregation.vala @@ +9,3 @@ private HashSet<string> _default_individuals; private string _individual_id_prefix = "telepathy:protocol:"; + private int test_timeout = 3; I forgot to mention before: we've recently adopted a coding style which mandates the prefixing of private member variables with underscores, so this should be _test_timeout.
Created attachment 178428 [details] [review] Added valgrind support in make check. Added underscore prefix to private field. Will merge this.
Merged. Thanks for reviewing!