GNOME Bugzilla – Bug 639352
Notifications for login and logout need love
Last modified: 2011-01-14 14:31:54 UTC
""" The correct form for login / logout notifications is: - The Avatar of the user in question, as the image - The Name of the user, as the title - The word "Connected" as the message body """ forwarded from: https://bugs.launchpad.net/ubuntu/+source/empathy/+bug/582757
Can you please attach a screenshot of the current notification so we'll have something to easily compare/discuss design.
Created attachment 178209 [details] attached
Created attachment 178298 [details] new version I think you're right, I do prefer this look.
Created attachment 178301 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/notif-639352 src/empathy-event-manager.c | 14 ++++++++------ 1 files changed, 8 insertions(+), 6 deletions(-)
Comment on attachment 178301 [details] [review] http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/notif-639352 Looks good to me. Just one comment: >+ header = g_strdup_printf (_("<b>%s</b>"), > empathy_contact_get_alias (contact)); Do we need to translate that? I can't imaging translations being different than that string, but maybe I'm wrong.
Good catch, I removed the _(). Merged to master, will be in 2.91.6. This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.