After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639291 - [xingmux] Return NULL instead of 0 for a function returning gboolean
[xingmux] Return NULL instead of 0 for a function returning gboolean
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
unspecified
Other Linux
: Normal normal
: 0.10.18
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-12 08:53 UTC by Yang Xichuan
Modified: 2011-01-24 18:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (887 bytes, patch)
2011-01-12 08:53 UTC, Yang Xichuan 		committed Details | Review

Description Yang Xichuan 2011-01-12 08:53:51 UTC 
Created attachment 178112 [details] [review]
patch

I found that in file gstxingmux.c, function parse_header(), has a "return 0", 
I think "return FALSE" is better
Comment 1 Sebastian Dröge (slomo) 2011-01-19 19:56:20 UTC 
Thanks, I'll push this after release.
Comment 2 Sebastian Dröge (slomo) 2011-01-24 18:46:01 UTC 
commit 904d0b9b603adb2b9afad2a29e7351e6b737df15
Author: Yang Xichuan <xichuan.yang@tieto.com>
Date:   Wed Jan 12 16:48:57 2011 +0800

    xingmux: Use FALSE instead of 0 as return value for a function returning gbo
    
    Fixes bug #639291.