After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 639219 - ges-internal.h shouldn't be installed
ges-internal.h shouldn't be installed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal blocker
: 0.10.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-11 15:41 UTC by Tim-Philipp Müller
Modified: 2011-01-11 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ges: Don't install ges-internal.h and hide the GES debug category symbols (1.70 KB, patch)
2011-01-11 16:20 UTC, Sebastian Dröge (slomo) 		none Details | Review
ges: Don't install ges-internal.h and hide the GES debug category symbols (2.30 KB, patch)
2011-01-11 16:25 UTC, Sebastian Dröge (slomo) 		none Details | Review

Description Tim-Philipp Müller 2011-01-11 15:41:03 UTC 
ges-internal.h should not be installed.
Comment 1 Sebastian Dröge (slomo) 2011-01-11 16:15:33 UTC 
And the symbols in ges-internal.h should start with an underscore or something to not get exported after bug #639218 is fixed.
Comment 2 Sebastian Dröge (slomo) 2011-01-11 16:20:26 UTC 
Created attachment 178059 [details] [review]
ges: Don't install ges-internal.h and hide the GES debug category symbols

Fixes bug #639219.
Comment 3 Sebastian Dröge (slomo) 2011-01-11 16:23:40 UTC 
Unfortunately this breaks the introspection build (but everything else works). No idea why it tries to do something with _ges_debug.


  GEN    GES-0.10.gir
g-ir-scanner: compile: gcc-4.5 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I.. -I.. -I/home/slomo/projects/gstreamer/head/gstreamer -I/home/slomo/projects/gstreamer/head/gstreamer/libs -I/home/slomo/projects/gstreamer/head/gst-plugins-base/gst-libs -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -c -o /home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/GES-0.10.o /home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/GES-0.10.c
g-ir-scanner: link: ../libtool --mode=link --tag=CC --silent gcc-4.5 -o /home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/GES-0.10 -export-dynamic -L. libges-0.10.la -pthread -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0 /home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/GES-0.10.o
/home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/.libs/lt-GES-0.10: symbol lookup error: /home/slomo/projects/gstreamer/head/gst-editing-services/ges/.libs/libges-0.10.so.0: undefined symbol: _ges_debug
Command '['/home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/GES-0.10', '--introspect-dump=/home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/types.txt,/home/slomo/projects/gstreamer/head/gst-editing-services/ges/tmp-introspectHAyuvU/dump.xml']' returned non-zero exit status 127
make[3]: *** [GES-0.10.gir] Error 1
Comment 4 Sebastian Dröge (slomo) 2011-01-11 16:25:44 UTC 
Created attachment 178060 [details] [review]
ges: Don't install ges-internal.h and hide the GES debug category symbols

Fixes bug #639219.
Comment 5 Edward Hervey 2011-01-11 17:23:21 UTC 
commit 8dff71aa08be0909365b1091d7d7e5f73762e079
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Tue Jan 11 17:19:54 2011 +0100

    ges: Don't install ges-internal.h and hide the GES debug category symbols
    
    Fixes bug #639219.