Created attachment 177865 [details] [review]
This patch fix the radio button where am I related cosmetic order problem

This patch fix this bug I hope, if not need changing any another control order spokening orders.

If you have a little time, please commit this patch if the patch is good.
I tested this patch for example with Orca preferences gui the general tab keyboard layout radiobutton group, now are hearing equals orders both normal and where am I output.

Attila

Review of attachment 177865 [details] [review]:

Thanks for the patch Attila. The thing is: The order was done that way for a reason. So the solution is not to change the order; rather it's to figure out why those short phrases are not getting translated correctly into Hungarian. Is it a case of agreement between adjective and noun, for instance? If so, I can solve that with a qualified string.

Ok, look now for hungarian language specific example I hope I writing right and full understandable my comment:
Orca sends now the radio button role type and selection state with three single translated string, radio button role type is translated in Orca hungarian language translation file with "választógomb" string, the selection state (selected) word is translated with "kiválasztott" string. If a radio button is not selected, this string (not selected string) is translated hungarian language with "nincs kiválasztva" string.
Following single strings are containing this translations:
#. Translators: spoken words for the rolename of a radio button.
#.
#: ../src/orca/rolenames.py:768
msgid "radio button"
msgstr "választógomb"

#. Translators: this is in reference to a radio button being
#. selected or not.
#.
#: ../src/orca/flat_review.py:382 ../src/orca/settings.py:1414
msgctxt "radiobutton"
msgid "selected"
msgstr "kiválasztott"

#. Translators: this is in reference to a radio button being
#. selected or not.
#.
#. Translators: this represents the state of a radio button.  It is
#. meant to be spoken to the user.
#.
#: ../src/orca/flat_review.py:387 ../src/orca/settings.py:1413
msgctxt "radiobutton"
msgid "not selected"
msgstr "nincs kiválasztva"

In hungarian language real speaking only right the "kiválasztott választógomb" (selected radiobutton) form, this is doing now my patch. If we keep the old using order with where am I output for radio button related, this order resulting a not correct but translated output for hungarian users, but of course this is not good unfortunately.
The advantage my patch only is not resolving new strings but resolve this order related problem, my purpose is doing compatible fix with Orca 2.32 maintenance version when I doed this patch.
But have another possibility this order related problem, if english users need the now original using where am I radiobutton order (radio button selected style spokened string), but this is only possible committing with master branch if we ready:
Need merging this three single translated strings with two strings:
#. Translators: spoken words for the rolename of a radio button and selected state.
#.
#: ../src/orca/rolenames.py:768
msgid "radio button selected"
msgstr "kiválasztott választógomb"
#. Translators: this is in reference to a radio button being
#. selected or not.
#.
#. Translators: this represents the state of a radio button.  It is
#. meant to be spoken to the user.
#.
#: ../src/orca/flat_review.py:387 ../src/orca/settings.py:1413
msgctxt "radiobutton"
msgid "radio button not selected"
msgstr "nincs kiválasztva választógomb"

Perhaps help for example if we replacing only the selection states translation strings (selected to checked, unselected to unchecked), because this is not resolving order related problem for hungarian language. This strings are used only radio buttons?
For example, if we only replacing the "selected" english original string with "checked" word, and not selected english string with "unchecked" word, this is resolving hungarian specific problem with where am I order, because this three single strings resulting following output:
"laptop választógomb bejelölve"
In english:
"laptop radiobutton checked"
But when we doing this, of course changing the order with unfocused formattings for radio button related.

Just a moment, I doing a little patch with shows the difference.

Attila

Created attachment 177909 [details] [review]
Second revision

Joanie, please look this bigger patch.
I changed the radio button selection state messages (selected and not selected strings) with src/orca/flat_review.py file and src/orca/settings.py file, and change the formatting orders with proper the new strings.
I tested this patch with normal radio buttons and radio buttons where am I output.
I am not full sure one thing:
I changed the pyatspi.ROLE_RADIO_MENU_ITEM formatting orders too, but I don't no this change producing problems or not.
I tested the pyatspi.ROLE_RADIO_MENU_ITEM formatting change for example with Nautilus view menu with check menu items, I not see any problem, but if you known a better example with possible testing the radio menu item formattings, please tell me a better application to I possible testing this new change.

Hopefuly this new patch are good,

Attila

Joanie, what your openion:
Need the pause after LabelAndName formatting part with radio button formatting?
Now my patch following string containing with unfocused radio button if the Break speech into chunks between pauses check box is checked:
    formatting['speech'][pyatspi.ROLE_RADIO_BUTTON]['unfocused'] = \
        'labelAndName + pause + roleName + radioState + pause + availability + lineBreak + ' + MNEMONIC + ' + accelerator + pause + positionInList + pause'

Perhaps better hearing  the radio button name, role name and selection state with one sentence?
I tryed cut two part with label and name strings, because if the radio button is unfocused, I would like only a pause after the radio button group label, for example Orca keyboard layout the "keyboard layout panel" string, and I think better hearing the "laptop radiobutton checked" string with one another sentence.
If my second patch you accept, how can I possible doing this change to testing purpose?
Attila

Joanie, because my second patch perhaps resulting a string change, have a chance to committing this patch with the master branch, or I choose absolute wrong way to fixing this bug?

If not, I full agree, but this case need choosing temporary my first patch to spokening Orca with right order the radiobutton where am I output.
The first way patch not resulting string change, only change the formatting order with src/orca/formatting.py file with where am I output related.
What the better method to fix this bug?

Attila

Joanie, possible commit my first or second patch bug fix after reviewing if my any patch fixing right this bug?

Attila

Attila, as I understand it, you are trying to "fix" something which was a design decision. And the reason you would like to do this is to make things work the way you would like them to work in Hungarian. Right??

Your proposed change would undo that design decision and change things for users of all languages. Therefore, that is not the way to go.

Joanie, you are right my second patch related (this patch changing the radiobutton related translations and formatting order for where am I operation).
The first patch doesn't change translations related texts, only change the spokening order with radio buttons related in where am I operation.
When I doing now where am I operation with radio buttons, now orca spokening following style with where am I output:
keyboard layout
laptop
radio button selected
If I focusing normal way with a radio button, Orca spokening following way the radiobuttons related informations:
keyboard layout
laptop
selected radio button

The problem is following:
All strings for translations are single strings, only hungarian translations doesn't possible resolving this problem. The second order resulting right hungarian translation for this output. In english, both two order is grammatical right I think.

With my src/orca/formatting.py related patch doesn't change any string. Not have chance to commit the first way fix patch?

Attila