After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638951 - Conversation windows resize after being shown
Conversation windows resize after being shown
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.32.x
Other Linux
: Low minor
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2011-01-07 22:32 UTC by Jean-François Fortin Tam
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
screencast (118.46 KB, video/ogg)
2011-01-07 22:32 UTC, Jean-François Fortin Tam
  Details
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/chat-resize-638951 (478 bytes, patch)
2011-03-30 11:51 UTC, Guillaume Desmottes
none Details | Review

Description Jean-François Fortin Tam 2011-01-07 22:32:50 UTC
Created attachment 177791 [details]
screencast

As you can see in the attached screencast, Empathy's chat windows don't adhere to this HIG suggestion: 
"Always show a window as soon as possible, but make sure your window is the correct size before displaying it. Resizing a window after it is visible is disorienting and gives an unpolished look to your application."

This is probably because the resize method is called after the show method or something like that.
Comment 1 Guillaume Desmottes 2011-01-10 13:21:29 UTC
Yeah nice catch. But IIRC it wasn't that easy to fix. :\
Comment 2 Guillaume Desmottes 2011-03-30 11:51:46 UTC
Created attachment 184686 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/chat-resize-638951

 src/empathy-chat-window.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
Comment 3 Emilio Pozuelo Monfort 2011-03-30 12:10:07 UTC
I love one liners. But I don't see empathy_window_present_with_time calling gtk_widget_show_all... am I missing something?
Comment 4 Guillaume Desmottes 2011-03-30 12:47:35 UTC
It calls gtk_window_present() which does what we need.
Comment 5 Emilio Pozuelo Monfort 2011-03-30 13:44:54 UTC
r+
Comment 6 Guillaume Desmottes 2011-03-30 13:50:28 UTC
I asked for the hard code freeze exception.
Comment 7 Guillaume Desmottes 2011-03-30 14:43:54 UTC
Approved. Merged to master and 2.34.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.