After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638873 - Please support libkibi
Please support libkibi
Status: RESOLVED WONTFIX
Product: nautilus
Classification: Core
Component: general
0.x.x [obsolete]
Other Linux
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-06 22:36 UTC by Benjamin Drung
Modified: 2011-01-24 15:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
add-libkibi-support-to-nautilus.patch (4.31 KB, patch)
2011-01-06 22:36 UTC, Benjamin Drung
none Details | Review
add-libkibi-support-to-nautilus-v2.patch (4.28 KB, patch)
2011-01-07 14:43 UTC, Benjamin Drung
rejected Details | Review

Description Benjamin Drung 2011-01-06 22:36:43 UTC
Created attachment 177710 [details] [review]
add-libkibi-support-to-nautilus.patch

Please add support for libkibi [1] (patch attached). libkibi is designed as replacement for g_format_size_for_display. It allows the user to select the preferred unit and implements Ubuntu's units policy [2].

[1] https://launchpad.net/libkibi
[2] https://wiki.ubuntu.com/UnitsPolicy
Comment 1 Benjamin Drung 2011-01-07 14:43:24 UTC
Created attachment 177751 [details] [review]
add-libkibi-support-to-nautilus-v2.patch

Updated patch attached.
Comment 2 André Klapper 2011-01-07 22:25:52 UTC
Maybe this is a chicken and egg question, but which apps/distributions use or plan to use/ship libkibi?
Comment 3 Benjamin Drung 2011-01-08 00:08:30 UTC
I plan to convert as many apps to use libkibi in Ubuntu 11.04, starting with brasero, nautilus, gnome-system-monitor, transmission, ... Non-glib C programs can use this library too (e.g. dvdbackup will use it).
Comment 4 Cosimo Cecchi 2011-01-10 11:16:50 UTC
Hi Benjamin, thanks for your patch.
The unit used for displaying file sizes have always been a heated topic for discussion; see e.g. [1] and [2]. The thread at [1] is particularly important for this matter, as it suggests something like what you're doing here should be provided by GLib itself.

I don't think using a separate library to configure that is worth the effort, and it causes fragmentation of our stack, so I am closing this as WONTFIX.

If a proper solution is implemented in GLib, then we can discuss whether the whole desktop should use one unit or the other, and stick to that.

[1] http://mail.gnome.org/archives/gtk-devel-list/2007-December/msg00237.html
[2] http://mail.gnome.org/archives/nautilus-list/2008-February/msg00008.html
Comment 5 Benjamin Drung 2011-01-24 15:55:19 UTC
I opened bug 640432 asking if adding libkibi's functionality to glib has a chance of being accepted before wasting my time with writing a patch that will be thrown away.