GNOME Bugzilla – Bug 638867
git master doesn't build against gnome-desktop-3
Last modified: 2011-01-07 20:45:15 UTC
make: Entering directory `/home/uws/Projects/Gnome/Development/src/gnome-screensaver/src'
gs-fade.c: In function ‘check_randr_extension’:
gs-fade.c:577: error: too many arguments to function ‘gnome_rr_screen_new’
gs-fade.c: In function ‘gs_fade_finalize’:
gs-fade.c:910: warning: implicit declaration of function ‘gnome_rr_screen_destroy’
gs-fade.c:910: warning: nested extern declaration of ‘gnome_rr_screen_destroy’
make: *** [gs-fade.o] Error 1
make: Leaving directory `/home/uws/Projects/Gnome/Development/src/gnome-screensaver/src'
It seems GnomeRRScreen is a fully featured GObject nowadays - see bug #630913 for more information.
Created attachment 177707 [details] [review]
Adapt to new constructor API and use g_object_unref instead of the (now dropped) custrom destroy function.
Looks good to me
Review of attachment 177707 [details] [review]:
Can you bump the required gnome-desktop version while committing this ?
I've committed it now.