After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638859 - textoverlay: make misc. properties controllable
textoverlay: make misc. properties controllable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.32
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-06 20:12 UTC by Lane Brooks
Modified: 2011-01-07 00:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (3.15 KB, patch)
2011-01-06 20:44 UTC, Lane Brooks
committed Details | Review

Description Lane Brooks 2011-01-06 20:12:10 UTC
This patch makes it so that silent, color, xpos, and ypos are contorllable parameters in the pango textoverlay. This lets you create a controller and effectively animate the position, color, and visibility of the textoverlay.

I had to modify the Makefile.am for this module to add -lgstcontroller-$(GST_MAJORMINOR) to the LIBADD variable. I am not sure why I had to do this given other elements I looked at (like alpha) don't do it. Can someone tell me the proper way to to do this?
Comment 1 Tim-Philipp Müller 2011-01-06 20:27:09 UTC
Did you forget to attach the patch by any chance?
Comment 2 Lane Brooks 2011-01-06 20:44:50 UTC
Created attachment 177702 [details] [review]
Patch
Comment 3 Tim-Philipp Müller 2011-01-07 00:07:15 UTC
Thanks, fixed it up a bit (call gst_controller_init(), Makefile.am, etc.):

commit b6ae6951747a7ae1f367dfacd94fb3a2c79eb54e
Author: Tim-Philipp Müller <tim.muller@collabora.co.uk>
Date:   Thu Jan 6 23:08:34 2011 +0000

    textoverlay: make text property controllable too
    
    Because we can, and because it's the most interesting one
    to control really, after xpos/ypos.

commit e67417833164c0ddf27248047637efad8088a607
Author: Lane Brooks <dirjud@gmail.com>
Date:   Thu Jan 6 23:01:20 2011 +0000

    textoverlay: make some properties controllable
    
    https://bugzilla.gnome.org/show_bug.cgi?id=638859


> I had to modify the Makefile.am for this module to add
> -lgstcontroller-$(GST_MAJORMINOR) to the LIBADD variable. I am not sure why I
> had to do this given other elements I looked at (like alpha) don't do it. Can
> someone tell me the proper way to to do this?

There's GST_CONTROLLER_{LIBS,CFLAGS} which is also what alpha/Makefile.am uses.