Code-In task: http://socghop.appspot.com/gci/task/show/google/gci2010/gnome/t129426437609

Few notes:

  a.) Please try to maintain a similar look and feel to the icons
      that are currently in place, they should look like they belong
      to the same set.

      If you want to change the style of the icons more dramatically
      (if you think that's appropriate) that's also ok, except in that
      case we need you to create replacements for the older icons so
      that the theme is uniform.

  b.) Please dont rely only on the list of warnings from Glade, Glade
      is not finished implementing widget classes for GTK+ 3.0 yet.

      Please instead refer to the GTK+ code base to derive what are
      the remaining missing icons that should eventually have support
      in Glade.

      Off the top of my head:
        - GtkToolPalette
        - GtkToolItemGroup
        - GtkAppChooser (is there also GtkAppChooserDialog ?)
        - GtkCellAreaBox
        - GtkComboBoxText
        - GtkGrid


Thanks for somebody finally looking into the missing icons !

Created attachment 177670 [details]
GTK+.zip

For the GtkSpinner, see here
http://library.gnome.org/devel/gtk/unstable/GtkSpinner.html that's how it looks like.

The ButtonBox is missing the arrow.

For the others, I (personally) feel that the arrow should be rounded and between the two boxes. Hope you can understand that, a bit like ↺

Created attachment 177679 [details]
GTK+2

Created attachment 177696 [details]
GTK+3

Created attachment 177697 [details]
GTK+4

Created attachment 177698 [details]
GTK+5.zip

Created attachment 177704 [details]
GTK+6.zip

OK, I think they look good like that. THanks!

Dolean, 
   I think they look better now too, can you please
provide the 16x16 & 22x22 versions along with the patch to 
the Makefiles in the plugins/gtk+/icons/ directory like
I requested on irc ?

That will let me see how the icons color and everything looks
inside Glade.

Thanks.

Juan Pablo and I agreed to just remove all of the orientable subclasses
from Glade's palette and reuse some of the icons that way.
(the older classes are still supported but only when loaded in already
created Glade files).

So we did end up using the GtkSpinner after running the icon through
gimp and updating the Makefile.am.

Any chance on seeing any more of the icons getting done ?

Some that I am more interested in are:
 - GtkCellRendererSpinner
 - GtkToolPalette
 - GtkToolItemGroup
 - GtkSwitch

Created attachment 182620 [details]
Icons for Switch, ToolItemGroup, ToolPalette and CellRendererSpinner

Created attachment 182629 [details]
Icons for Grid, AppChooserDialog and ComboBoxText

Thanks for your effort !

A few things should be done to make your icons fit into the
current icon set:

  - GtkCellRendererSpinner

    Please take a look at the existing cell renderer icons,
    spinner should be easy enough to fit into the same
    paradigm (i.e., all the cell renderers have a solid
    horizontal line on top and on the bottom, with something
    descriptive in the middle).

    Can you please make a spinner icon that fits into the same
    look/color/size as the other cell renderer icons ?

 - GtkToolPalette/GtkToolItemGroup

    I like the concept you used here, my only complaint is that
    after loading the icons into Glade they introduce a dramatically
    different base color from the other icons (the colored parts are
    fine in my opinion, just the group headers are notably much
    darker than the gray tones used in all the other icons).

Note that I only looked at GtkSwitch in an image viewer and it doesnt
look like how it will look in Glade, it is probable that the color tone
is also slightly off, other than that it looks fine to me.

Thanks again for your efforts, can you please extend your efforts
to make the icons "fit" into the current icon set a bit better ?

(In reply to comment #15)
> Thanks for your effort !
> 
> A few things should be done to make your icons fit into the
> current icon set:
> 
>   - GtkCellRendererSpinner
> 
>     Please take a look at the existing cell renderer icons,
>     spinner should be easy enough to fit into the same
>     paradigm (i.e., all the cell renderers have a solid
>     horizontal line on top and on the bottom, with something
>     descriptive in the middle).
> 
>     Can you please make a spinner icon that fits into the same
>     look/color/size as the other cell renderer icons ?

Sorry this one was my bad, it looks like I'm confused with older
icons... your spinner icon does indeed seem to fit well into
the current icon set :)

Hi,
  I've committed the GtkAppChooserDialog, GtkCellRendererSpinner
and GtkComboBoxText icons.

Actually when loading in Glade the GtkComboBoxText icon appears to be
slightly smaller than the combobox icon which looks a little bit odd,
but the color tone looks ok and it's not a big problem... I'm not
even sure if it's just psychological (maybe the GtkComboBox *looks*
bigger just because it isnt cluttered with the "txt" in the middle).

I'll take a look at integrating GtkSwitch into Glade and seeing
the icon there.

Note that we wont be needing the GtkGrid icon in the end, however
it looks like you had the same idea as we did (just reuse the
GtkTable icon).

Recently I've removed all the GtkH/V* subclasses from Glade's
palette, they are still supported at load time but since we
can use the base classes there is no reason to add those subclasses
in Glade and make the palette look more complex/cluttered than
it needs to be.

So I've just recycled the icons from the subclasses and used
them for widgets such as GtkScale, GtkScrollbar, GtkSeparator,
GtkBox, GtkButtonBox etc... also since GtkTable will soon be
deprecated since it does nothing more than GtkGrid already
does, I've also removed the GtkTable from the palette and
reused the icon for GtkGrid.

To get an updated list of exactly which icons are still missing,
you can always fire up Glade from git master and see the warning
message at startup. We still have a couple unimplemented classes
that wont show up in the warning, those are:
  - GtkSwitch (which you already took care of :))
  - GtkInfoBar
  - GtkTearoffMenuItem
  - GtkCellAreaBox

Thanks again for your efforts.

Here's an idea I just had for GtkTextTag/GtkTextTagTable
(the non-widget objects are always harder to visualize of course).

What if a GtkTextTag looked like a "tag", something like
a military dog tag or the tags you put on your luggage
when you take an airplane... if using fixed font should
be able to interpret this ascii:

  /--------------|
 /               |
+ O    Text      |
 \               |
  \--------------|

To consume less space, it could just use a capital "A"
(like in the fontchooser widgets).

And a GtkTextTagTable could be the same icon but appear
to be in a pile (a pile of tags):

  /--------------|
 / /--------------|
+ / /--------------|
 + /               |
  + O    Text      |
   \               |
    \--------------|

Just a thought I wanted to share with anyone paying attention
to creating icons :)

I'll try to adjust the colors for the toolpalette/itemgroup but the problem is I can't easily test it in glade because I can't get it working in jhbuild.

I like your idea for TextTable so I'm going to do it soon.

For the InfoBar do you think I can just draw a light-yellow box with two boutons on the right ?

(In reply to comment #19)
> I'll try to adjust the colors for the toolpalette/itemgroup but the problem is
> I can't easily test it in glade because I can't get it working in jhbuild.
> 

hmmm, well if it's too much trouble to build...

you could cheat... and just copy your icons over some
existing icons in the Glade that does install on your system.

i.e.
 cp widget-gtk-toolpalette.png /usr/share/glade3/pixmaps/hicolor/16x16/actions/widget-gtk-hbox.png

and then look at the icon for GtkHBox in Glade 3.6 for example.

> I like your idea for TextTable so I'm going to do it soon.
> 

:)

> For the InfoBar do you think I can just draw a light-yellow box with two
> boutons on the right ?

I think that would be fine, basically infobar is a dialog's action area
that usually comes with a message... maybe the light-yellow box should
also come with some scribbles that look like text on the left ?

You will know better than me though, maybe the text scribble just doesn't fit.

Created attachment 182762 [details]
ToolThings, TextTag(Table), InfoBar and TearOffMenuItem

Here I go for some new icons:
 - I changed the color scheme for ToolPalette and ToolItemGroup
 - The Infobar looks weird, I tried with two dark lines for the text but it's as weird.

For the CellAreaBox I don't have many ideas, maybe a CellRender* with nothing in it, or filled with dots like GtkFixed ?

Looking great.

 - The ToolPalette/ToolItemGroup has a good color to match the
   other icons now.

 - The TearOffMenuItem is simple and perfect as far as I can see.

 - I like seeing the text tags, in the inspector :)

   However I think maybe we should be using bolder text for the "A",
   that would be more consistent with the icons we currently have 
   in place for GtkLabel, GtkAccelLabel and GtkFontSelectionDialog.

   That also goes for the GtkComboBoxText actually, maybe we should
   be using a bold capital "A" in there instead of the thin "txt"
   string.

 - The info bar is a little odd, I think that the buttons are supposed
   to be beside each other and not on top of each other, maybe it would
   be better if there was only one button, leaving more space for a 
   text like effect on the left... (maybe again another bold capital
   letter "A" would be enough, if we use the capital letter "A" to
   symbolize the idea of text in the icons, it should be consistant
   and descriptive as an icon... I think).

   However, for now I added it as is, feel free to improve the info bar
   icon if you want (I'm happy to have one at least :)).

So all of those icons are now added in git master.

For the GtkCellAreaBox, I think it would be good to reuse the
graphic theme of the GtkBox icon.

Maybe it could be like a cell renderer, with 2 horizontal or vertical 
lines in it showing how it's 'splitting up space'.

Note that GtkCellAreaBox is the first cell area class in GTK+3, I'm not
sure if an when one will be written but I anticipate the eventual addition
of GtkCellAreaTable (and if/when we add GtkCellAreaTable to GTK+, we can
then use the same theme as the GtkGrid icon inside the cell renderer icon).

Also, now that we have a GtkAppChooserDialog icon I think we should use
that graphic concept to create GtkAppChooserWidget icon and GtkAppChooserButton,
The AppChooserWidget icon should be easy (look in the "composite widgets"
group and you'll see that they are mostly just the dialog icons without the
surrounding border)... the app chooser button will be a little more difficult
but I think you can manage to just take that inner blue area of the 
appchooserdialog icon and cram it into a button-like border.

Some insight about the missing icons that we can try to brainstorm on.

We have few non-graphic things left to represent with icons, some main
ones are "filters" 
  - GtkTreeModelFilter
  - GtkRecentFilter
  - GtkFileFilter

And we have "buffers"
  - GtkEntryBuffer
  - GtkTextBuffer

If we can think of something that can represent a "filter" or
"buffer" then those should be easier to do ... however nothing
really good comes to mind right now :-/

Some more ideas:
  - GtkTreeSelection: maybe this could be like the GtkTreeView icon but
                      with one of the lines highlighted in blue (kindof
                      like how you did with app chooser dialog).
  - GtkStatusIcon:    This one could probably be a square button with a yellow
                      "glowing" spot (something to look like a status
                      indicator, just a thought).
  - GtkTreeViewColumn: Maybe this one could just be "half" of the treeview
                       icon (like the treeview icon, but only taking half
                       the width).
  - GtkOffscreenWindow: This one could probably be the same as GtkWindow
                        but with a "faded" effect (slightly lighter colors 
                        or such).
  - GtkAccelGroup:   This is an object that holds a list of accelerators and
                     I suppose it's seldomly used in Glade, however maybe 
                     GtkAccelLabel can help as inspiration (maybe a CNTL-C
                     or just an F1 rendered in a box with the "stacked" 
                     effect you gave to GtkTextTagTable).

Some widely used non-widget objects that would be great to have icons 
for are GtkAdjustment and GtkSizeGroup... I dont have any concrete ideas
right now but I think drawing rulers could be involved here...

Created attachment 182896 [details]
A lot of icons

Great!
I modified GtkComboBoxText, GtkTextTag(Table) and GtkInfoBar to use a capital A letter.

I also created an icon for GtkCellAreaBox, following your idea, and GtkAppChooser(Button).

I had an idea for *Filter so I tested it (only in 16x16), please tell me if you understand the metaphor.

I like the filter idea, can't think of anything better either.

I added the other new icons and updated the updates (and obsoleted
all the patches with icons that are already applied or wont be).

I think the bolder "A" looks better now in texttag and comboboxtext...

However InfoBar still looks odd somehow :-/

Anyway, you seem to be doing a great job at this so I'll leave
info bar to your discretion...

Created attachment 183006 [details]
New icons

So I've done some new icons:
 - *Buffer : I followed the way GtkListStore was drawn
 - *Filter for 22x22
 - AccelGroup and TreeSelection
 - TreeViewColumn for 22x22 as there's already one for 16x16

I also removed the buttons from InfoBar and changed the colors, it fits more in the theme but I don't know if one will understand what it represents.

Ok, committed all of these.

I'm still also unsure about info bar, I think the first attempt was
the best so far.

Awesome we got this far, for the record, there are only these remaining:

GladeUI-Message: Glade needs artwork; a default icon will be used for the following classes:
	GtkStatusIcon	needs an icon named 'widget-gtk-statusicon'
	GtkRecentChooserMenu	needs an icon named 'widget-gtk-recentchoosermenu'
	GtkAdjustment	needs an icon named 'widget-gtk-adjustment'
	GtkTreeModelSort	needs an icon named 'widget-gtk-treemodelsort'
	GtkRecentManager	needs an icon named 'widget-gtk-recentmanager'
	GtkSizeGroup	needs an icon named 'widget-gtk-sizegroup'

I think for GtkTreeModelSort we can do the opposite of GtkTreeModelFilter

data } filtered data

data { sorted data

does that make sense ?

Actually one more thing would be great to have in the icon set.

What I need is a 22x22 and 16x16 icon for a deprecated widget.

Currently we use gtk-dialog-warning for all deprecated widgets,
but what I wanted to do, is have a transparent background with
a red circle and cross (like a no-smoking sign or such).

Then if we have that image, when a widget is deprecated, I'll
composite the red-circle and cross over the already existing
icon for that class... which will IMO be much nicer than
just using a warning icon instead.

Created attachment 183032 [details]
TreeModelSort, Deprecated

For GtkTreeModelSort I just took the icon of GtkTreeStore and added a blue arrow to show that we sort the TreeStore.

I drew the deprecated red circle for in both sizes, and made a test in 22x22 for Adjustment and SizeGroup. GtkSizeGroup looks ok to me, but GtkAdjustment needs more work.

Awesome on the deprecated.png.

I added that along with some logic to composite it on top of
existing icons that are marked deprecated, the results are
really sweet... however you currently have to go and set
a widget class to be deprecated in gtk+.xml.in to actually see
it (since for GTK+ 3.0 we're starting with all deprecated widgets
already removed).

I'll take another look at the other icons tomorrow, I think we
have a general problem of contrast in the icons... some of the
icons dont show up well on a dark background... mostly I'm
concerned about the *Filter ones that contain the '{' symbol
which is hardly visible on a dark-blue background (which is
my active widget state color here with no theme installed).

Created attachment 183041 [details]
Example of how deprecated icons look

Here, take a look at how deprecated widgets look in the palette :)

Great!

Do you think the GtkSizeGroup icon is understandable ?

I tried to add a border to the '{' in filters icons be not successfully yet, I'll do some more tests.

Created attachment 183179 [details]
SizeGroup, StatusIcon, *Filter

Added new icons.

The "{" symbol indeed renders better this way.

  - GtkFileFilter has problems when rendering on
    a dark background (the file icons show up with
    weird little dots around them).

  - The GtkAdjustment sample looks good, but could probably also
    use a little bit more play with dropshadow or such so as to
    stand out properly on a darker background.

  - The GtkTreeModelSort is generally a good idea, but could also
    use some work (it would be nice if the arrow had some outline or
    dropshadow, maybe in this case the same colors as were
    used for the "{" symbol would be better than the cyan blue.

I'm satisfied with GtkSizeGroup and GtkStatusIcon, I added these
icons today along with the updates for the *Filter icons.

That leaves us finally with the last classes with no icons committed:
  GtkRecentChooserMenu
  GtkRecentManager
  GtkTreeModelSort
  GtkAdjustment

Maybe the little colorful icons should be used somehow for
GtkRecentChooserMenu and for GtkRecentManager (since those
are now used for GtkRecentFilter).

Maybe GtkRecentChooserMenu should be the GtkMenu icon using the
colorful little icons at the beginning of the grey lines... and
then it would be great to update GtkRecentAction (which currently
just looks like a menuitem & submenu) to also use the little colorful
icon things.

Created attachment 183286 [details]
Recent*, TreeModelSort...

Did you see the new icons ?

Just took a look at it now.

  o GtkRecentManager is oddly colorful but I think it's alright.

  o I like the changes to GtkRecentAction and the new GtkRecentChooserMenu

  o I think that GtkTreeModelSort looks off when sitting beside GtkTreeModelFilter
    I think that it would look much more 'professional' if the same color scheme
    as the '{' symbol were used for the arrow (i.e. darkest gray solid arrow with
    a hint of very light gray dropshadow... at least that's what the '{' looks
    like to me).

  o Honestly I liked the last GtkAdjustment better than this one, it looked
    more like the arrow was pointed at some ruler or measure, while this
    one is less descriptive and brings unnecessary extra attention to itself
    by using the unusual white and blue colors.

I did not look at UIManager yet, however I still have no plans for 
implementing that in Glade so I could just add your icon for the sake
of the icon set itself, anyway...

Created attachment 183789 [details]
TreeModelSort, Adjustment

Here I go,
I don't like the adjustment icon but if you think it's easily comprehensive that's ok.
For the TreeModelSort I've just added a white drop shadow.

TreeModelSort does indeed look like a better fit this way thanks :)

The adjustment, well, I still think you did it best the first time, maybe we
should just live with the problem of it not showing well on a dark background.
(i.e. the first one really looked like a ruler, while the second one was a stack
of white boxes on top of a blue box, and this one looks like the back of a 
book or binder, or a hair comb).

I'll try digging up the original adjustment from the history and see if
I can't think of anything, maybe keeping the strong lines the way they are
and just adding some white.... I don't know, maybe we don't need the white
(GtkTreeStore for instance has the same issue with dark backgrounds anyway).

I think we have a just about complete icons set now though ! 

Thanks SO much for your efforts !

Created attachment 183807 [details]
Adjustment

My "first" GtkAdjustment with a white drop shadow.
:-)

Great !

Give me a day to apply this and double check everything, but I think
we've covered everything and we can then close the bug.

Also, it would be great if you could give us a tarball with all
the raw svgs of your work, that way I can hide it somewhere on the net
(or it can even just stay here in bugzilla history), and one day
if we need more icons the next artist will have something to
work with.

Actually I don't have raw svgs, I just used The GIMP to draw the icons. But as an advice for the next artist I'd say : follow the old icons style, the color scheme, and reuse as much as possible old icons parts.

Ok, closing the bug with a complete icon set !

Thank you so much Florent for your patience and work.