After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638700 - buttons: Fix background functions for non-default layouts
buttons: Fix background functions for non-default layouts
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2011-01-04 21:29 UTC by Florian Müllner
Modified: 2011-02-03 20:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
buttons: Fix background functions for non-default layouts (7.23 KB, patch)
2011-01-04 21:30 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2011-01-04 21:29:58 UTC 
Patch ported from mutter commit 9f2581318 - see bug 635686 for details.
Comment 1 Florian Müllner 2011-01-04 21:30:00 UTC 
Created attachment 177522 [details] [review]
buttons: Fix background functions for non-default layouts

While the configured layout is taken into account for positioning
the buttons, the mapping from button function states to button
position states just assumed the default button layout in LTR
locales.
Do a proper mapping depending on the actual layout instead.
Comment 2 Thomas Thurman 2011-02-03 20:13:18 UTC 
Review of attachment 177522 [details] [review]:

Looks very sensible. Committed.