After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638571 - Simplify button's tooltip is not useful
Simplify button's tooltip is not useful
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: general
1.9.1
Other Linux
: Normal enhancement
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-03 13:56 UTC by Victor Vargas
Modified: 2011-10-01 10:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch that fixes the issue (1005 bytes, patch)
2011-02-14 16:57 UTC, rugby471
needs-work Details | Review
Updated patch on suggestion (972 bytes, patch)
2011-09-10 14:31 UTC, Timothy Arceri
none Details | Review
Updated patch on suggestion (977 bytes, patch)
2011-09-10 14:45 UTC, Timothy Arceri
committed Details | Review

Description Victor Vargas 2011-01-03 13:56:57 UTC
This report was originally filled at:
https://bugs.launchpad.net/ubuntu/+source/banshee/+bug/693318

1) Go to The 'Now Playing' screen by clicking on the first item ('Now Playing') in the sidebar.
2) In the toolbar, hover over the 'Simplify' button.

The tooltip (en_GB) given is:
"Simplify the Now Playing Interface by hiding the source list and more"

This tooltip is not effective as it repeats the text in the button - not needed, and give a vague description of the changes.

It should instead be replaced by something more informative and precise, such as:
"Hide the source list, main menu, status bar and currently playing information."

ps:original reporter is using 1.9.0 series but is still reproducible under 1.9.1 too.
Comment 1 rugby471 2011-02-14 16:57:46 UTC
Created attachment 180841 [details] [review]
Patch that fixes the issue

Attached is a patch (against latest git) which fixes the issue, it changes the tooltip to:

"Hide the source list, menu bar, status bar and currently playing media information."

This provides a lot more detail, to exactly what the button does (AFAIK the purpose of a tooltip).
Comment 2 Gabriel Burt 2011-02-26 19:48:52 UTC
Comment on attachment 180841 [details] [review]
Patch that fixes the issue

"currently playing media information" might be confusing, since we don't hide the information displayed inside Now Playing itself.  Maybe replace that with "toolbar"?
Comment 3 Timothy Arceri 2011-09-10 14:31:09 UTC
Created attachment 196175 [details] [review]
Updated patch on suggestion

Updated patch inline with suggestion
Comment 4 Timothy Arceri 2011-09-10 14:45:47 UTC
Created attachment 196177 [details] [review]
Updated patch on suggestion

Updated again to make tooltip better for when simplify is already selected. "Hide/Show"
Comment 5 Bertrand Lorentz 2011-09-10 16:54:33 UTC
Review of attachment 196177 [details] [review]:

Thanks for the patch.

"tool, and status bars" should probably be "toolbar and status bar".

We are currently in string freeze for the 2.2 release on September 21st, so I'm marking this to be committed after the release, with the above change.
Comment 6 Bertrand Lorentz 2011-10-01 10:04:24 UTC
Comment on attachment 196177 [details] [review]
Updated patch on suggestion

Committed with the changes described in my previous comment
Comment 7 Bertrand Lorentz 2011-10-01 10:04:41 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.