After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638510 - [PATCH] X_LIBS missing for sticky notes and trash applet, they do not compile
[PATCH] X_LIBS missing for sticky notes and trash applet, they do not compile
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
: 640356 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2011-01-02 13:26 UTC by Enrico Minack
Modified: 2011-03-26 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fixes missing reference to X lib (687 bytes, patch)
2011-01-02 13:26 UTC, Enrico Minack 		none Details | Review
error for compiling sticky notes applet (1.87 KB, text/plain)
2011-01-04 15:30 UTC, Enrico Minack 		  Details
error for compiling the trash applet (1.57 KB, text/plain)
2011-01-04 15:30 UTC, Enrico Minack 		  Details

Description Enrico Minack 2011-01-02 13:26:24 UTC 
Created attachment 177348 [details] [review]
fixes missing reference to X lib

Make complains about missing reference to X lib since X_LIBS is missing for *_LDADD for sticky notes and trash applet. Fixed by following patch. Why does this break, suddenly?
Comment 1 André Klapper 2011-01-03 21:36:47 UTC 
(In reply to comment #0)
> Why does this break, suddenly?

Please provide the make output. :)
Comment 2 Enrico Minack 2011-01-04 15:29:30 UTC 
Sorry, here they come ...
Comment 3 Enrico Minack 2011-01-04 15:30:24 UTC 
Created attachment 177488 [details]
error for compiling sticky notes applet
Comment 4 Enrico Minack 2011-01-04 15:30:53 UTC 
Created attachment 177489 [details]
error for compiling the trash applet
Comment 5 Enrico Minack 2011-01-04 15:33:36 UTC 
Btw., the same problem occurred in other projects as well:
- gnome-panel (gtk3 branch)
- libwnck (gtk3 branch)

I am using a fresh installation of Ubutnu 11.04 (development branch).
Comment 6 Kjartan Maraas 2011-01-26 19:17:56 UTC 
*** Bug 640356 has been marked as a duplicate of this bug. ***
Comment 7 Germán Poo-Caamaño 2011-01-26 19:33:30 UTC 
The problem is arised when you use binutils.gold.

binutils.gold (ld.gold) is faster than the GNU ld,
but it is also stricter and raise the issues.

For more reference: http://lwn.net/Articles/274859/
(the series of blog posts linked in the article are 
 quite good).
Comment 8 Germán Poo-Caamaño 2011-01-26 19:34:32 UTC 
I do not think it is critical, because with GNU ld it just
compile.  However, the Makefile is missing the X_LIB.
Comment 9 Josselin Mouette 2011-03-21 21:40:45 UTC 
Actually the problem arises when you use GCC 4.5, at least on Debian/Ubuntu. Even without binutils-gold, it will pass --no-add-needed to the linker.

I think the patch is correct.
Comment 10 Enrico Minack 2011-03-26 10:18:41 UTC 
patch committed to master head in http://git.gnome.org/browse/gnome-applets/commit/?id=99f91d51c5e18bc86cdc425dbe4e3a280e9b8f63