After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638475 - Rating cell causes warning on mouseover
Rating cell causes warning on mouseover
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2011-01-02 00:04 UTC by Christoph Wolk
Modified: 2011-08-17 11:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This patch makes ListView create a CanvasManager and assign it to all CanvasItems that it creates. (2.04 KB, patch)
2011-04-27 20:53 UTC, Mackenan Grassi
committed Details | Review

Description Christoph Wolk 2011-01-02 00:04:00 UTC
I'm using Banshee and BCE from Ubuntu daily/unstable ppas.

Every time I move the mouse over a rating cell in the main track list, I see the following output:

[1 Warn  00:54:35.011] Asked to invalidate 0+0,0x0 for Hyena.Data.Gui.ColumnCellRating but no CanvasManager!
Comment 1 David Nielsen 2011-01-02 00:27:38 UTC
Confirming
Comment 2 Mackenan Grassi 2011-04-27 20:53:35 UTC
Created attachment 186779 [details] [review]
This patch makes ListView create a CanvasManager and assign it to all CanvasItems that it creates.

It looks like all CanvasItems expect a CanvasManager to be assigned to it (or at least to the root CanvasItem in the case of a tree of CanvasItems. ListView appears to play much the same roll as CanvasHost (though far more complex), but doesn't currently create a CanvasManager or assign it. This can be seen when any mouse-related events cause CanvasItems (such as ColumnCellRating and ColumnCellCheckBox) to call InvalidateRender. This leads eventually to a check for CanvasManager and a warning to be thrown if there is none assigned.
Comment 3 Bertrand Lorentz 2011-08-17 11:39:56 UTC
Comment on attachment 186779 [details] [review]
This patch makes ListView create a CanvasManager and assign it to all CanvasItems that it creates.

Committed. Thanks for the patch, and sorry it took so long to process it !
Comment 4 Bertrand Lorentz 2011-08-17 11:40:10 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.