After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638239 - [LiveRadio] ShoutCast API changed to 2.0 - need Developer Key (blocked on legal grounds currently, extension disabled by default)
[LiveRadio] ShoutCast API changed to 2.0 - need Developer Key (blocked on leg...
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Community Extensions
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-29 04:30 UTC by Frank Ziegler
Modified: 2012-03-23 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to adapt Shoutcast module to API 2.0 (3.18 KB, patch)
2010-12-29 04:30 UTC, Frank Ziegler
committed Details | Review
Alter shoutcast module to support user defined developer key (26.95 KB, patch)
2011-01-26 04:08 UTC, Frank Ziegler
none Details | Review

Description Frank Ziegler 2010-12-29 04:30:51 UTC
Created attachment 177172 [details] [review]
Patch to adapt Shoutcast module to API 2.0

The Shoutcast Module of LiveRadio has stopped working due to a change in API. For the new API a Developer Key is needed that has to be applied for at http://dev.aol.com/SHOUTcast

I have created a patch reflecting the API changes to version 2.0, but I have not applied for a developer key as I do not feel in a position to judge the License Agreement.
Comment 1 David Nielsen 2010-12-29 09:27:56 UTC
The patch looks good, I did a quick comparison with http://dev.aol.com/SHOUTcast/documentation and everything seems in order in terms of the new API. I don't know what process we use when applying for dev keys for Banshee though.
Comment 2 Bertrand Lorentz 2010-12-29 16:14:54 UTC
I had a quick look at the "Partner License Agreement", and here's what I think might be issues :

Section 4.1 : not record content from the radio stations.
Wouldn't that be a problem with the StreamRecorder extension ?

Section 4.3 : make the end-user terms of service accessible somewhere in the UI through a link to http://www.shoutcast.com/disclaimer

Section 4.10 : "keeping your Developer ID confidential". It's going to be in the source code...

Section 6.4 : provide a logo with link to www.shoutcast.com in the UI

Section 6.6 : promote the SHOUTcast Radio toolbar and bundle it in our "product"

That last one is probably the most problematic : the toolbar is only available for Windows and Mac OS X, so we would have to bundle it if we ever provide binaries of the LiveRadio extension for those platforms.

Apparently, VLC had issues with that agreement :
http://www.videolan.org/press/2010-1.html


I couldn't find the form to request a developer key, apparently you need to ask by e-mail for now :
http://www.shoutcastblog.com/2010/09/30/shoutcast-api-update/

I'll try again in a week or so, to see if the form is available. If not I'll contact the people listed in that post.
Comment 3 Bertrand Lorentz 2010-12-30 10:12:07 UTC
Comment on attachment 177172 [details] [review]
Patch to adapt Shoutcast module to API 2.0

Frank has committed the patch, without a real developer key. The shoutcast plugin is disabled for now.
Comment 4 Frank Ziegler 2011-01-25 09:03:03 UTC
I created a version of the module that allows the user to add his own Developer Key. The module is inactive as long as no key is entered, but it can be configured through the tools menu. I have not commited the code, yet, as I would like to ask first, if resolving the issue like that is feasible or not.
Comment 5 Frank Ziegler 2011-01-26 04:08:08 UTC
Created attachment 179350 [details] [review]
Alter shoutcast module to support user defined developer key
Comment 6 Gabriel Burt 2011-02-11 01:45:51 UTC
I think if this is the kind of fix that's needed, we should just drop support for it.
Comment 7 Frank Ziegler 2011-02-11 03:17:57 UTC
Sad but true. I just had another look at the rhythmbox plugin, which got about 1500 downloads and makes users add their own key. They have also added a "secret" internet location with a key provided by the developer, but that would not comply with the licensing at all, i.e. be de facto illegal.

For anyone interested, there is this patch here anyway, but I am going to leave the module deactivated as is now, not applying the patch. I'll give it some time to see if the shoutcast regulations will change in time (I doubt it) and then possibly remove shoutcast support alltogether or separate it into a new extension that could comply with the licensing terms.
Comment 8 Gregor Wenkelewsky 2011-03-06 22:31:26 UTC
Please do not drop Shoutcast support. It is still the largest directory of internet radio stations of all the world in the world.

Though this licensing stuff really sucks, I can see it too.

But a much better way than to just resign and drop this is to be more clever! And if that is the best way, then allow the user to easily add his own Developer Key. And maybe someone stumbles upon the key in Winamp and all is fine. :) Or likewise.

Those other tools - xiph.org, podcasts, magnatune, lastfm and the radio section - are no alternative to shoutcast.
Comment 9 Frank Ziegler 2011-04-29 04:01:40 UTC
Shoutcast is working again in LiveRadio with a change I committed yesterday.
Comment 10 Gregor Wenkelewsky 2012-02-03 00:38:56 UTC
Super! Since which version of Banshee is it working again, 2.0.1?
Comment 11 Avery 2012-03-23 20:12:37 UTC
This bug still is not resolved, as of 2.4. What is it about the licensing that is different from Guayadeque that makes this feature impermissible in Banshee but workable in Guayadeque (and apparently Rhythmbox)?