After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638143 - [PATCH] Missing files dialog: formatter does not correctly compare mappings when searching for probable matches
[PATCH] Missing files dialog: formatter does not correctly compare mappings w...
Status: RESOLVED FIXED
Product: pitivi
Classification: Other
Component: General
Git
Other Linux
: Normal major
: 0.14
Assigned To: Jean-François Fortin Tam
Pitivi maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-27 23:24 UTC by Jean-François Fortin Tam
Modified: 2011-05-24 01:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
the patch (2.38 KB, patch)
2010-12-28 00:43 UTC, Jean-François Fortin Tam 		none Details | Review

Description Jean-François Fortin Tam 2010-12-27 23:24:47 UTC 
When we load a project with missing files, we ask the user to tell us the new location of the first missing file; afterwards, the addMapping method (in formatters/base.py) checks if the other missing files can be found in that same new path.

There is a bug in that method's algorithm, because it keeps prompting me for every file even though their new location is the same.
Comment 1 Jean-François Fortin Tam 2010-12-28 00:41:17 UTC 
Commit 7a486d2bfe7acfee2deafd9c9edd2a8cb914bf91 in my "better-missing-files-dialog" branch fixes this (but you should merge the whole branch while you're at it :)
Comment 2 Jean-François Fortin Tam 2010-12-28 00:43:25 UTC 
Created attachment 177112 [details] [review]
the patch

Contents of commit 7a486d2bfe7acfee2deafd9c9edd2a8cb914bf91
Comment 3 Jean-François Fortin Tam 2011-05-24 01:16:15 UTC 
Now in master.

commit a558480a8c6adc38c64bb4c16607d10af300b1de
Author: Jean-François Fortin Tam <nekohayo@gmail.com>
Date:   Mon Dec 27 18:36:27 2010 -0500

    Correctly "guess" the new path of missing media files
    
    (make sure that the URIs compared in addMapping have similar encodings)
    Fixes bug #638143