After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638138 - GenPod show property default values
GenPod show property default values
Status: RESOLVED FIXED
Product: gnome-perl
Classification: Bindings
Component: Glib
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtk2-perl-bugs
gtk2-perl-bugs
Depends on:
Blocks:
 
 
Reported: 2010-12-27 21:57 UTC by Kevin Ryde
Modified: 2011-08-17 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.54 KB, patch)
2010-12-27 21:57 UTC, Kevin Ryde 		reviewed Details | Review
patch 2 (5.08 KB, patch)
2011-08-17 01:14 UTC, Kevin Ryde 		committed Details | Review

Description Kevin Ryde 2010-12-27 21:57:21 UTC 
Created attachment 177107 [details] [review]
patch

I'd be good if the properties sections of the docs showed the default value for each property, to see the sense of various settings, widths of borders, etc.

Perhaps something like attached.  (It was meant to be simply $pspec->get_default_value stuck into the output, but formatting it nicely slightly grew :-).
Comment 1 Torsten Schoenfeld 2011-08-16 19:20:29 UTC 
Review of attachment 177107 [details] [review]:

Fantastic patch!  Only one minor quibble...

::: lib/Glib/GenPod.pm
@@ +545,3 @@
+  my $type = $pspec->get_value_type;
+
+  if ($type->isa('Glib::Boolean')) {

... it seems like this needs to "$type eq 'Glib::Boolean'", right?  Because Glib::Boolean->isa('Glib::Boolean') is actually false.
Comment 2 Kevin Ryde 2011-08-17 01:14:08 UTC 
Created attachment 194002 [details] [review]
patch 2

Ah, yep, new diff.
Comment 3 Torsten Schoenfeld 2011-08-17 21:58:15 UTC 
Thanks a lot, committed.