After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 638073 - about characters issue
about characters issue
Status: RESOLVED FIXED
Product: giggle
Classification: Other
Component: libgiggle-git
0.5
Other Linux
: Normal normal
: ---
Assigned To: giggle-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-27 02:45 UTC by 林刚
Modified: 2011-10-24 12:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Escape commit messages correctly (1.39 KB, patch)
2011-06-01 22:18 UTC, Denis Jasselette
none Details | Review

Description 林刚 2010-12-27 02:45:47 UTC
i got a issue while committing changes with Chinese characters in commit log, it will convert Chinese to '\344\270\255\346\226\207\346\230\257\344\270\252\351\227\256\351\242\230 ', but it works fine if i commit with git command directly.already set 'quotapath=false' in .gitconfig, but failed too.
Comment 1 Denis Jasselette 2011-06-01 22:18:44 UTC
Created attachment 189044 [details] [review]
Escape commit messages correctly

This bug occurred because of g_strescape which messes up with utf8 characters.

This fix simply implements a function escaping only '\' and '"' in a utf8 string.
Comment 2 Javier Jardón (IRC: jjardon) 2011-10-24 12:31:50 UTC
Hello Denis,

thanks for the patch and sorry for the delay.

This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.

http://git.gnome.org/browse/giggle/commit/?id=9a8d291172621d4b6e26704d596e2c98fcacdcf5