After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637930 - Profiles are not always written out correctly
Profiles are not always written out correctly
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.91.x
Other All
: Normal normal
: 2.91.5
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
profiles
Depends on:
Blocks:
 
 
Reported: 2010-12-24 10:50 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2011-02-19 21:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Attila's user-settings.conf (8.12 KB, text/plain)
2010-12-24 10:52 UTC, Joanmarie Diggs (IRC: joanie)
Details
Halim's user-settings.conf (5.43 KB, text/plain)
2010-12-24 10:53 UTC, Joanmarie Diggs (IRC: joanie)
Details
My user-settings.conf - no duplication (5.38 KB, text/plain)
2010-12-24 11:41 UTC, Joanmarie Diggs (IRC: joanie)
Details
My user-settings.conf test 2 - no duplication (5.33 KB, text/plain)
2010-12-24 12:17 UTC, Joanmarie Diggs (IRC: joanie)
Details

Description Joanmarie Diggs (IRC: joanie) 2010-12-24 10:50:54 UTC
Something somewhere is causing us to write out the same <insert setting here> to both the default and the user-created profile. As a result, it seems like we're not correctly loading certain settings. The reality, once I commit the fix for bug 637667, is that we are. But the settings are the same.
Comment 1 Joanmarie Diggs (IRC: joanie) 2010-12-24 10:52:03 UTC
Created attachment 176999 [details]
Attila's user-settings.conf

Duplicated keybindings.
Comment 2 Joanmarie Diggs (IRC: joanie) 2010-12-24 10:53:53 UTC
Created attachment 177000 [details]
Halim's user-settings.conf

Duplicate speech server stuff.
Comment 3 Joanmarie Diggs (IRC: joanie) 2010-12-24 11:41:33 UTC
Created attachment 177009 [details]
My user-settings.conf - no duplication

No duplicated stuff.

What I did:
1. Delete user-settings.conf
2. Launch Orca, landed in prefs dialog
3. Kept speech dispatcher, selected espeak, saved profile
4. Kept speech dispatcher, selected "dummy", saved profile

What I got:
1. A basically empty default profile
2. A correct "espeak" profile
3. A correct "dummy" profile

How this is different from Attila and Halim:
1. They have a full default profile
2. They have a single user-created profile which
   duplicates stuff from default
Comment 4 Joanmarie Diggs (IRC: joanie) 2010-12-24 12:17:23 UTC
Created attachment 177011 [details]
My user-settings.conf test 2 - no duplication

This time I:

1. Deleted my user-settings.conf

2. Selected espeak and a faster rate and pressed Apply (i.e. to save these settings to the default profile)

3. Selected "dummy" and a slower rate and saved this as a profile.

The structure of this user-settings.conf looks more like what Halim and Attila have, namely a default profile which is filled out and an alternative profile. However, in mine there is still no duplication and things are working as expected.
Comment 5 Joanmarie Diggs (IRC: joanie) 2010-12-24 12:25:42 UTC
Adding Attila and Halim to the CC list.

I've so far taken two approaches to saving my settings. In comment 3, I made no changes to the default profile and have two profiles with no duplication. In comment 4, I saved some speech settings and then made one new profile with different speech settings. This latter attempt results in similar files to yours, but without duplication.

Given that you both can reproduce this problem and I cannot, please give me very, very specific steps that I can follow exactly and without any question/room for interpretation. What I need to be able to do is *generate* the user-settings.conf that you guys are getting on my machine. Thanks.
Comment 6 Hammer Attila 2010-12-24 13:05:10 UTC
Joanie, I doed following prewious:
1. I deleted the user-settings.conf and restart Orca. I landed the preferences dialog.
2. I setted all default I would like (speech rates, pitch, speak tutorial messages check box, speak child position etc).
3. I clicked save as button when I finish this task and copyes this settings with a new profile.
4. I choosed the active profile combo box with new profile and changed some keystrokes. Perhaps this is the mistake with first user-settings.conf file because I possible forgot load button before I begin redefining the shortcuts with new profile. :-(:-(
5. Clicked the Ok button after redefined the shortcuts.
So: because possible prewious I forgot load the new profile, Orca stores this modifyed shortcut keys with default profile with first user-settings.conf?

I found some issues with very interesting with end users related:
1. When I choosing a profile with startup profile combo box and click load button, the settings is not applied.
Perhaps happening this a missunderstood me because I not clicking OK button after the load dialog is closed (I clicked ofcourse the yes button), my system is not full stable now (for example not closed Orca preferences dialog when I click OK button, but this is not real bug, only a system error).
If I choosing a startup profile with startup profile combo box and click OK button with preference dialog, the settings is not applied before I not restart Orca.
Startup profile is not higher priority with active profile change?
Or I missunderstood this function?

2. When an user changing only the active profile and click OK button  (but forgot click the load button and load new profile prewious), the active profile name is changed with active profile combo box, but the settings is not applied.
This is right?

Attila
Comment 7 Joanmarie Diggs (IRC: joanie) 2010-12-24 17:46:36 UTC
(In reply to comment #6)

> 1. When I choosing a profile with startup profile combo box and click load
> button, the settings is not applied.

The load button loads the profile in the 'Active Profile' combo box. Not the one in the Start up combo box.

> If I choosing a startup profile with startup profile combo box and click OK
> button with preference dialog, the settings is not applied before I not restart
> Orca.

The Start up profile is the profile which should be automatically loaded when you start up Orca. If you click OK, you are not restarting Orca.

> Startup profile is not higher priority with active profile change?
> Or I missunderstood this function?

It's not a priority thing. There are two profiles:

1. What should be used right now (the active profile, you must load it)

2. What should be used by default when Orca starts up.
 
> 2. When an user changing only the active profile and click OK button  (but
> forgot click the load button and load new profile prewious), the active profile
> name is changed with active profile combo box, but the settings is not applied.
> This is right?

This is how it currently it. Whether or not it is how it should be seems to be something worthy of discussion.
Comment 8 Trevor Saunders (IRC: tbsaunde) 2011-02-19 12:51:34 UTC
Since the backend has been changed to json I don't hink this is still an issue right?
Comment 9 Joanmarie Diggs (IRC: joanie) 2011-02-19 21:40:57 UTC
To be honest, I don't think it was the json backend that fixed it; I think it was some changes I made elsewhere (i.e. when fixing other associated bugs when the profiles change was originally made).

Anyhoo, yes, I do believe this bug no longer exists. Closing it. Thanks Trev!