After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637893 - Port terminal plugin to libpeas/gtk3
Port terminal plugin to libpeas/gtk3
Status: RESOLVED FIXED
Product: gedit-plugins
Classification: Other
Component: General
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on: 624856
Blocks:
 
 
Reported: 2010-12-23 19:03 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2019-03-23 20:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
terminal v1 (26.06 KB, patch)
2010-12-23 19:03 UTC, Ignacio Casal Quinteiro (nacho)
committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2010-12-23 19:03:56 UTC
Created attachment 176961 [details] [review]
terminal v1

I'm not able to test it, somehow I'm not able to load any python plugin anymore.
Comment 1 Ignacio Casal Quinteiro (nacho) 2010-12-27 19:53:17 UTC
Pushed with some modifications, we still need to fix a few things but we need chpe for that.
Comment 2 jessevdk@gmail.com 2010-12-27 20:20:37 UTC
Maybe for keeping track you can mention what currently is not working/missing.
Comment 3 Ignacio Casal Quinteiro (nacho) 2010-12-27 20:23:59 UTC
1) currently, we are not getting the gnome-terminal settings, just our own settings. For this we must wait for gnome-terminal.
2) fork_command_full is not executed as I've not idea what params I have to put there.
3) set_colors commented because I've no idea how to convert a GdkRGBA to a GdkColor in python

Apart from that it should be ok.
Comment 4 Ignacio Casal Quinteiro (nacho) 2011-02-20 14:04:11 UTC
The terminal plugins is now working, we are still not getting the settings from gnome-terminal but we cannot do anything about this yet. gnome-terminal has to be ported to gsettings first.
Comment 5 Christian Persch 2011-02-20 14:29:08 UTC
... which it won't before 3.1 at the earliest (bug #624856).