After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637867 - Seeking resets position to beginning of song
Seeking resets position to beginning of song
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: playing
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-23 10:07 UTC by ville.ranki
Modified: 2013-06-19 21:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix play seek scale. (2.85 KB, patch)
2013-06-12 11:22 UTC, Phillip Wood
none Details | Review
Fix play seek scale. (4.74 KB, patch)
2013-06-12 11:27 UTC, Phillip Wood
none Details | Review
Fix play seek scale. (5.34 KB, patch)
2013-06-18 13:08 UTC, Phillip Wood
committed Details | Review

Description ville.ranki 2010-12-23 10:07:29 UTC
While playing a track moving the seek slider anywhere causes track to restart playing from beginning. 

Tested on Ubuntu 10.10 x86_32
Comment 1 Phillip Wood 2013-06-12 11:22:40 UTC
Created attachment 246609 [details] [review]
Fix play seek scale.

In the transition from glade to gtkbuilder the adjustment for
seek_scale went AWOL. As a result that slider didn't move in playback
and trying to seek with the mouse rewound the track to the start
because the range for the scale wasn't properly initialized. This fix
adds the adjustment back into the UI file, updates the scale widget to
GtkScale and fixes seeking with the keyboard as well.

N.B. The keyboard fix bumps the minimum GTK version requirement to 3.2
Comment 2 Phillip Wood 2013-06-12 11:27:53 UTC
Created attachment 246610 [details] [review]
Fix play seek scale.

In the transition from glade to gtkbuilder the adjustment for
seek_scale went AWOL. As a result that slider didn't move in playback
and trying to seek with the mouse rewound the track to the start
because the range for the scale wasn't properly initialized. This fix
adds the adjustment back into the UI file, updates the scale widget to
GtkScale and fixes seeking with the keyboard as well.

N.B. The keyboard fix bumps the minimum GTK version requirement to 3.2
Comment 3 Phillip Wood 2013-06-18 13:08:43 UTC
Created attachment 247136 [details] [review]
Fix play seek scale.

In the transition from glade to gtkbuilder the adjustment for
seek_scale went AWOL. As a result that slider didn't move in playback
and trying to seek with the mouse rewound the track to the start
because the range for the scale wasn't properly initialized. This fix
adds the adjustment back into the UI file, updates the scale widget to
GtkScale and fixes seeking with the keyboard as well.

N.B. The keyboard fix bumps the minimum GTK version requirement to 3.2
Comment 4 Christophe Fergeau 2013-06-19 16:36:34 UTC
Review of attachment 247136 [details] [review]:

Looks good, thanks!
Comment 5 Christophe Fergeau 2013-06-19 16:36:37 UTC
Review of attachment 247136 [details] [review]:

Looks good, thanks!
Comment 6 Christophe Fergeau 2013-06-19 21:06:11 UTC
Attachment 247136 [details] pushed as 053b72e - Fix play seek scale.