After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637866 - Mis-matched all patterns with returned failure message by passwd will make GUI hang
Mis-matched all patterns with returned failure message by passwd will make GU...
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: [obsolete] about-me
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-23 09:47 UTC by Richard
Modified: 2011-01-21 12:07 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Richard 2010-12-23 09:47:04 UTC
OS: Ubuntu 10.4
Steps:
   1. enter the current password in the Entry, and make it authenticated.
   2. enter "New password" and "Retype new password" with same words but short length.

Usually, if the passwd is using the system built-in pam module (pam_unix.so), the returned failure message will contain the "short" keyword, so it is ok to show error in GUI. But if user configure the passwd to use other third-party pam module and the returned failure message did not contain all the hard-coded pattern in the first 64 bytes, the GUI will hang until to click "Close" button.

Proposal:
     At least, if all patterns are missed, just show the original failure message from passwd to GUI.

In static gboolean
io_watch_stdout (GIOChannel *source, GIOCondition condition, PasswordDialog *pdialog)
...
    } else if (g_strrstr (str->str, "failure") != NULL) {
        /* Authentication failure */
        msg = g_strdup (_("Your password has been changed since you initially authenticated! Please re-authenticate."));

----> Here show the original message is perfered. Thanks!


        passdlg_set_auth_state (pdialog, FALSE);
    }
}
Comment 1 Bastien Nocera 2011-01-21 12:07:27 UTC
about-me is gone from GNOME 3.x, and the bug does not apply to the user accounts panel.