After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637747 - "Edit > Preferences > General > Visibile Columns > BPM" missing mnemonic
"Edit > Preferences > General > Visibile Columns > BPM" missing mnemonic
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: User Interface
HEAD
Other Linux
: Normal trivial
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-21 14:32 UTC by André Klapper
Modified: 2014-08-03 09:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing mnenonic (34.86 KB, application/x-designer)
2012-02-11 18:08 UTC, alex 		  Details
add missing mnenonic (with anjuta related changes) (26.71 KB, patch)
2012-02-11 18:37 UTC, alex 		none Details | Review
add missing mnenonic (_BPM) (588 bytes, patch)
2012-02-12 14:50 UTC, alex 		committed Details | Review

Description André Klapper 2010-12-21 14:32:37 UTC 
#: ../data/ui/general-prefs.ui.h:2
msgid "BPM"

This is missing a mnemonic.
Comment 1 alex 2012-02-10 16:09:44 UTC 
I think the bug is already solved:
1. the file doesn't exist anymore
2. the bpm radio button is acting like the other radio buttons
Comment 2 André Klapper 2012-02-11 17:20:50 UTC 
(In reply to comment #1)
> I think the bug is already solved:
> 1. the file doesn't exist anymore

It still exists, see:
http://git.gnome.org/browse/rhythmbox/tree/data/ui/general-prefs.ui

> 2. the bpm radio button is acting like the other radio buttons

That's unrelated to the problem described here: A missing mnemonic.
Comment 3 alex 2012-02-11 18:08:51 UTC 
Created attachment 207354 [details]
add missing mnenonic

the mnenonic for BPM is on B
(_BPM)
Comment 4 André Klapper 2012-02-11 18:17:10 UTC 
(In reply to comment #3)
> Created an attachment (id=207354) [details]
> add missing mnenonic

Thanks! 
Looks correct, but a patch (containing only your changes) would be more welcome than attaching a complete file. See http://live.gnome.org/Git/Developers
(plus it's "mnemonic").
Comment 5 alex 2012-02-11 18:32:44 UTC 
I used anjuta for fixing it. I noticed that there are more changes in the file. If you want, I can condense it to the mnemonic.
Comment 6 alex 2012-02-11 18:37:01 UTC 
Created attachment 207356 [details] [review]
add missing mnenonic (with anjuta related changes)
Comment 7 alex 2012-02-12 14:50:42 UTC 
Created attachment 207391 [details] [review]
add missing mnenonic (_BPM)
Comment 8 alex 2012-07-27 14:47:29 UTC 
is something wrong with my last patch?
Comment 9 Jonathan Matthew 2014-08-03 09:15:06 UTC 
I pulled out the relevant bits and pushed them as commit a6b1f33; not sure why this sat around for two years (though the format issues didn't help).  Sorry about that.