After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637699 - JavaScript wizard
JavaScript wizard
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: Plugins: class-gen
git master
Other Linux
: Normal enhancement
: ---
Assigned To: Armin Burgmeier
Anjuta maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-20 22:26 UTC by Kenny Meyer
Modified: 2010-12-23 08:57 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
Add JavaScript wizard to class gen plugin (41.17 KB, patch)
2010-12-20 22:26 UTC, Kenny Meyer 		needs-work Details | Review
Add JavaScript wizard to class gen plugin (43.77 KB, patch)
2010-12-20 23:59 UTC, Kenny Meyer 		committed Details | Review

Description Kenny Meyer 2010-12-20 22:26:30 UTC 
Created attachment 176796 [details] [review]
Add JavaScript wizard to class gen plugin

This bug contains a patch which adds a JavaScript wizard to the existing class-gen plugin.

The JavaScript class is based on the GJS base template. Current key features:
 - Adding class methods
 - Adding class variables
 - Adding imports
 - Supports prototypical inheritance.

To see how that looks like with GJS, read here [1].

[1] http://git.gnome.org/browse/gjs/tree/doc/Style_Guide.txt

It's 100% based on the examples from that document.

Adding imports: I'm not sure if adding imports in the wizard is obvious/helpful to users. Maybe it's not really needed. Please, tell me what you think.

I started off working from git HEAD, and it should be also compatible to the previous Python wizard commit.
Comment 1 Johannes Schmid 2010-12-20 23:49:48 UTC 
Review of attachment 176796 [details] [review]:

Overall coding seems nice but the template file is missing from the patch. Please add it using "git add".

Thanks"
Comment 2 Kenny Meyer 2010-12-20 23:59:44 UTC 
Created attachment 176804 [details] [review]
Add JavaScript wizard to class gen plugin

Added the JavaScript template. Sorry for forgetting that.
Comment 3 Johannes Schmid 2010-12-23 08:57:29 UTC 
Review of attachment 176804 [details] [review]:

Looks good!

Thanks!