After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637676 - Patch to popsquares.c needs header
Patch to popsquares.c needs header
Status: RESOLVED FIXED
Product: gnome-screensaver
Classification: Deprecated
Component: general
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-screensaver maintainers
gnome-screensaver maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-20 17:02 UTC by olbrannon
Modified: 2011-01-08 13:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add missing include in popsquares.c (312 bytes, patch)
2010-12-20 17:02 UTC, olbrannon 		none Details | Review

Description olbrannon 2010-12-20 17:02:58 UTC 
Created attachment 176770 [details] [review]
add missing include in popsquares.c

Complete build log and system info http://bugs.gentoo.org/show_bug.cgi?id=347899

The patch applies cleanly and there is a build log after applying there as well. 

the error reported is

QA: other                                                                    
│
│QA Notice: Package has poor programming practices which may compile         
 │
│           fine but exhibit random runtime failures.                        
 │
│popsquares.c:52:10: warning: implicit declaration of function 'exit'        

Attaching patch
Comment 1 André Klapper 2010-12-29 17:34:52 UTC 
Which exact version is this about? 2.30.2?
Comment 2 Pacho Ramos 2010-12-29 18:19:29 UTC 
Yes: 2.30.2
Comment 3 Matthias Clasen 2011-01-08 13:11:26 UTC 
This is fixed in git master already