After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637543 - Improve gvfs-copy and gvfs-move
Improve gvfs-copy and gvfs-move
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-18 23:43 UTC by Frederick Grose
Modified: 2014-04-18 19:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gvfs-copy: Make the progress output usable (2.36 KB, patch)
2014-04-17 07:46 UTC, Ross Lagerwall 		none Details | Review
gvfs-copy: Improve the interactive overwrite (1.40 KB, patch)
2014-04-17 07:46 UTC, Ross Lagerwall 		none Details | Review
gvfs-copy: Show progress for interactive copy (940 bytes, patch)
2014-04-17 07:46 UTC, Ross Lagerwall 		none Details | Review
gvfs-move: Improve progress output (2.17 KB, patch)
2014-04-17 07:46 UTC, Ross Lagerwall 		none Details | Review
gvfs-move: Improve the interactive overwrite (1.40 KB, patch)
2014-04-17 07:46 UTC, Ross Lagerwall 		none Details | Review
gvfs-move: Show progress for interactive move (940 bytes, patch)
2014-04-17 07:46 UTC, Ross Lagerwall 		none Details | Review

Description Frederick Grose 2010-12-18 23:43:43 UTC 
When gvfs-copy --progress is used at the commandline, the progress reporting overflows the display on a large file copy.

Please quiet this display by replacing the g_print template \n with \r in the show_progress() function.  This should overwrite the progress line with updated information and prevent the display overflow.
Comment 1 André Klapper 2010-12-30 19:28:09 UTC 
gvfs has nothing to do with gnome-vfs. Moving.
Comment 2 Ross Lagerwall 2014-04-17 07:46:11 UTC 
Created attachment 274570 [details] [review]
gvfs-copy: Make the progress output usable

Rather than spamming the screen with output, rate-limit the updates and
make them display over each other.
Comment 3 Ross Lagerwall 2014-04-17 07:46:16 UTC 
Created attachment 274571 [details] [review]
gvfs-copy: Improve the interactive overwrite

Mimic the output of cp by displaying the full URI and put a space
between the output and the user's input.
Accept either lower or upper-case 'y'.
Comment 4 Ross Lagerwall 2014-04-17 07:46:20 UTC 
Created attachment 274572 [details] [review]
gvfs-copy: Show progress for interactive copy

If requested, show progress for an interactive copy.
Comment 5 Ross Lagerwall 2014-04-17 07:46:24 UTC 
Created attachment 274573 [details] [review]
gvfs-move: Improve progress output

Rather than spamming the screen with output, rate-limit the updates and
make them display over each other.  Also calculate the speed of
transfer.
Comment 6 Ross Lagerwall 2014-04-17 07:46:28 UTC 
Created attachment 274574 [details] [review]
gvfs-move: Improve the interactive overwrite

Mimic the output of mv by displaying the full URI and put a space
between the output and the user's input.  Accept either lower or
upper-case 'y'.
Comment 7 Ross Lagerwall 2014-04-17 07:46:32 UTC 
Created attachment 274575 [details] [review]
gvfs-move: Show progress for interactive move

If requested, show progress for an interactive move.
Comment 8 Matthias Clasen 2014-04-18 16:11:12 UTC 
Looks all good to me
Comment 9 Ross Lagerwall 2014-04-18 19:33:27 UTC 
Pushed to master as d9b8dda613ba847b6696f58d5dccfff5bf5e0ad0.  Thanks for the review, Matthias.