GNOME Bugzilla – Bug 637520
Gtk+ seems to have broken Mutter
Last modified: 2010-12-21 19:28:45 UTC
Today after rebuilding the Gnome-Shell stack with Jhbuild, I couldn't move windows by dragging their titlebar: the whole shell would crash 100% of the times.
fmuellner quickly cooked up a Mutter patch:
However, from the IRC log:
<bochecha> fmuellner_, your patch fixes the crash, I can drag windows and use the edge tiling
<fmuellner_> bochecha: ok, but this is still a bug
<fmuellner_> bochecha: specifically, it's a gtk+ bug
<fmuellner_> the mutter patch replaces deprecated gtk+ api, but "deprecated" != "we're gonna segfault your app"
<fmuellner_> (commit 56c3d4b1be looks suspicious)
So here is the mandatory bug report.
For a quicker reference, the changeset fmuellner is talking about is:
* 56c3d4b Remove dead Gtk[Rc]Style code
Created attachment 176710 [details] [review]
Created attachment 176711 [details] [review]
Please describe the change in behaviour you are seeing.
What is different that makes mutter crash ?
bug 637531 contains some more investigation.
*** Bug 637531 has been marked as a duplicate of this bug. ***
I've just pushed a fix in commit 33cd32f7968f, thanks for the bug report
Created attachment 176777 [details] [review]
Return an appropriate GtkStyle from gtk_rc_get_style_by_paths()
I don't think using a default GtkStyleContext with a dummy path
from gtk_style_new() does all that much good.
better compatibility is always worthwhile if GtkStyle is to stay, patch looks great to me
Attachment 176777 [details] pushed as a2dddb1 - Return an appropriate GtkStyle from gtk_rc_get_style_by_paths()