After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637425 - [PATCH] fix icon canvas item accessibility
[PATCH] fix icon canvas item accessibility
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 633145 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-12-17 01:35 UTC by Alban Browaeys
Modified: 2010-12-17 14:01 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
fix icon canvas item accessibility (15.35 KB, patch)
2010-12-17 01:35 UTC, Alban Browaeys
none Details | Review
icon-canvas-item: attempt to fix up a11y for NautilusIconCanvasItem (28.62 KB, patch)
2010-12-17 14:01 UTC, Cosimo Cecchi
committed Details | Review

Description Alban Browaeys 2010-12-17 01:35:37 UTC
Created attachment 176570 [details] [review]
fix icon canvas item accessibility

since the switch to ginitiallyunowned we need to
implement icon canvas item accessibility as an AtkGobjectAccessible.
Comment 1 Cosimo Cecchi 2010-12-17 10:45:34 UTC
*** Bug 633145 has been marked as a duplicate of this bug. ***
Comment 2 Cosimo Cecchi 2010-12-17 14:01:04 UTC
I pushed to master a different patch, which tries to fix NautilusIconCanvasItem a11y using a more modern ATK approach instead of EelAccessibility functions.
Thanks for you patch!

The following fix has been pushed:
184096f icon-canvas-item: attempt to fix up a11y for NautilusIconCanvasItem
Comment 3 Cosimo Cecchi 2010-12-17 14:01:11 UTC
Created attachment 176591 [details] [review]
icon-canvas-item: attempt to fix up a11y for NautilusIconCanvasItem

Based on an initial patch by Alban Browaeys <prahal@yahoo.com>.