After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637226 - rygel installs 120x120 icons, instead of 128x128
rygel installs 120x120 icons, instead of 128x128
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: general
git master
Other Linux
: Low minor
: ---
Assigned To: Jens Georg
Depends on:
Blocks:
 
 
Reported: 2010-12-14 14:17 UTC by Vincent Untz
Modified: 2011-10-06 06:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
data: Add 128x128 px version of the icons (31.03 KB, patch)
2011-10-04 10:58 UTC, Jens Georg 		none Details | Review
data: Split in theme icons and DLNA icons (1.24 KB, patch)
2011-10-04 10:58 UTC, Jens Georg 		none Details | Review
core: Do not use theme icons for UPnP (1.10 KB, patch)
2011-10-04 10:58 UTC, Jens Georg 		none Details | Review

Description Vincent Untz 2010-12-14 14:17:44 UTC 
I don't know why rygel installs 120x120 icons, but it's wrong: the usual size is 128x128.
Comment 1 Zeeshan Ali 2010-12-15 14:48:37 UTC 
The reason is that DLNA requires that we provide icons of sizes 120x120 and 48x48 in both jpeg and png. So these I must provide but if providing them in 128x128 as well makes everyone happy, I'll be glad to comply. :)
Comment 2 Zeeshan Ali 2010-12-15 14:49:46 UTC 
Section 7.2.28 in "DLNA guidelines" if anyone is interested.
Comment 3 Vincent Untz 2010-12-15 16:48:09 UTC 
(In reply to comment #2)
> Section 7.2.28 in "DLNA guidelines" if anyone is interested.

Hrm, I can't find the right document, it seems.

The thing is that you install those icons in the icon theme. But the icon theme doesn't know about the 120x120 size, so I'm not even sure they will be used. If you really need this size, I suggest you handle it outside of the usual theming.

Also, jpeg is not a supported format for icon themes: http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
Comment 4 Jens Georg 2010-12-15 16:55:56 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Section 7.2.28 in "DLNA guidelines" if anyone is interested.
> 
> Hrm, I can't find the right document, it seems.

I'd be surprised if you can, it's quite expensive…
Comment 5 Zeeshan Ali 2010-12-15 18:17:31 UTC 
(In reply to comment #3)
> (In reply to comment #2)
> > Section 7.2.28 in "DLNA guidelines" if anyone is interested.
> 
> Hrm, I can't find the right document, it seems.

  Welcome to world of DLNA's world of pain. :) The documents are not public.

> The thing is that you install those icons in the icon theme. But the icon theme
> doesn't know about the 120x120 size, so I'm not even sure they will be used. If
> you really need this size, I suggest you handle it outside of the usual
> theming.

  Agreed but what does that mean? I install the icons in a different location?

> Also, jpeg is not a supported format for icon themes:
> http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html

  Ok, I'll deal with jpegs the same way i'll deal with non-standard sizes.
Comment 6 Vincent Untz 2010-12-15 18:22:24 UTC 
(In reply to comment #5)
> (In reply to comment #3)
> > The thing is that you install those icons in the icon theme. But the icon theme
> > doesn't know about the 120x120 size, so I'm not even sure they will be used. If
> > you really need this size, I suggest you handle it outside of the usual
> > theming.
> 
>   Agreed but what does that mean? I install the icons in a different location?

I'd just install the icons in /usr/share/rygel.
Comment 7 Jens Georg 2011-10-04 10:58:13 UTC 
Created attachment 198210 [details] [review]
data: Add 128x128 px version of the icons
Comment 8 Jens Georg 2011-10-04 10:58:21 UTC 
Created attachment 198211 [details] [review]
data: Split in theme icons and DLNA icons
Comment 9 Jens Georg 2011-10-04 10:58:24 UTC 
Created attachment 198212 [details] [review]
core: Do not use theme icons for UPnP
Comment 10 Jens Georg 2011-10-06 06:52:31 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.