After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637157 - Calling nautilus --help from a terminal quits the application
Calling nautilus --help from a terminal quits the application
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-13 16:31 UTC by Alban Browaeys
Modified: 2011-05-24 17:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
local handling of nautilus switches and fix for remote (5.91 KB, patch)
2010-12-13 16:31 UTC, Alban Browaeys
reviewed Details | Review

Description Alban Browaeys 2010-12-13 16:31:11 UTC
Created attachment 176344 [details] [review]
local handling of nautilus switches and fix for remote

The  handling of the command line was done in the remote process.
Thus an unknown command like --help would kill the main thread as it was processed remotely.
Thus use the local_command_line handler to process locally the command line and  ignore unknown commands and help request remotely.
In the process fix a bug with the application quit, that is it was using release twice but the refcount could increment more than twice thus an invocation of quit would fail. Use application quit_mainloop instead for the non exit with last window use case.
Comment 1 Cosimo Cecchi 2010-12-13 19:11:36 UTC
Review of attachment 176344 [details] [review]:

Thanks for the patch; I pushed a fix for the quit issue you mentioned, and cleaned-up the exit-with-last-window preference in the meanwhile, as it's really not useful anymore now that nautilus doesn't handle session services.
I am still not convinced about handling local_command_line like you do, for the 'help' issue; this will needs a bit more thinking, or something like https://bugzilla.gnome.org/show_bug.cgi?id=634990
Comment 2 Cosimo Cecchi 2011-05-24 17:58:36 UTC
This is fixed now in master.
As the fix is a bit invasive, I am not sure whether I will backport it in
3.0.2, but it might appear in a later Nautilus stable version.