GNOME Bugzilla – Bug 637081
Port EMap widget to GTK+ 3
Last modified: 2013-09-13 01:10:25 UTC
I ported the EMap widget to GTK+ 3 for the gnome-system-tools. Attached are
the changes I made, adapted to Evolution. These all require GTK3 (they
won't be added to GTK+ 2.x), so I'm mostly dumping them here not to lose them,
but of course you cannot commit them until Evo switches completely.
Created attachment 176288 [details] [review]
Port EMap widget to GtkScrollable
Needed to build with GTK3.
Created attachment 176289 [details] [review]
Port EMap widget to height-for-width API
Needed by GTK3.
Created attachment 176290 [details] [review]
Use GdkVisual instead of GdkColormap in EMap widget
GdkColormap no longer exists in GTK3.
Created attachment 176291 [details] [review]
Use GtkWidget::draw in EMap widget
GtkWidget ::expose-event no longer exists in GTK3.
We don't need to check gtk_widget_is_drawable() because GTK does it
Some lines look ugly because tabs are replaced with spaces, but the file isn't consistent at all in that regard (if you look closely, you'll notice Company's work is the culprit ;-). Running indent after that could be a good idea.
Thanks for patches. The code changed quite much since you've done this. So it
a) doesn't apply cleanly to gtk3 branch of evolution,
which is gtk3 only already.
b) the last three patches are obsolete in that branch
c) even when I add changes from the first patch then it doesn't compile.
I'll try to fix it next week.
Created commit 69f3641 in gtk3 branch (maybe 2.91.6+, or slightly later)