GNOME Bugzilla – Bug 637032
[PATCH] Add support to GObjectIntrospection
Last modified: 2011-02-22 00:11:08 UTC
GObjectIntrospection allows bindings like gjs or pygobject to use libnm, thus allowing a NM client in Javascript or Python (actually many others). This is required for the future network indicator in gnome-shell.
Created attachment 176247 [details] [review] Add GObjectIntrospection support Add the necessary annotations (the mininum required, that is those on return values. NULL parameters or container types may require more), and the Autotools stuff to get a NetworkManager GIR for libnm-util and a NMClient for libnm-glib. Based on top of the rm-userset branch.
Hey, thanks a lot, looks like good work. I saw some trivial bits that I pulled out and committed separately since they are applicable to both 0.8.x and master. I'll review the rest of the patch soon!
Created attachment 177276 [details] [review] Add GObjectIntrospection support Add the necessary annotations (the mininum required, that is those on return values. NULL parameters or container types may require more), and the Autotools stuff to get a NetworkManager GIR for libnm-util and a NMClient for libnm-glib. Based on top of the rm-userset branch. Updated on current master, also includes a compatible API change (nm_remote_settings_new now accepts NULL, which is required for bindings which don't have DBusGConnection)
Created attachment 178338 [details] [review] Add GObjectIntrospection support Add the necessary annotations (the mininum required, that is those on return values. NULL parameters or container types may require more), and the Autotools stuff to get a NetworkManager GIR for libnm-util and a NMClient for libnm-glib. Also, some minor bug fixes. Rebased and extended for WiMax.
Thanks again! Pushed as: 3ebecd2a295b40081321d1b3f26fb1204fe5d4c4
Reopening because the addition of new functions make introspection fail, some functions are still missing from the linker script, and some annotations are just useless (marking GHashTables of gpointer). Patch coming.
Created attachment 179038 [details] [review] More GObjectIntrospection fixes Fix some annotations, add the necessary ones for new functions, and ensure that all public symbols are exported.
Created attachment 181415 [details] [review] More GObjectIntrospection fixes Fix some annotations and add the necessary ones for new functions. Updated to master.
Split into 3: e77acd43b663b3e1011f812bc506c176f65d1415 3b57350dd6d1f1b48119eb66dc170aaf2aef1dc3 8bc774fe16039add71f68ea7f7e5a739803803bf Thanks!