After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 637023 - glade files don't install in the proper place
glade files don't install in the proper place
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
2.91.x
Other Linux
: Normal normal
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2010-12-11 15:56 UTC by Emilio Pozuelo Monfort
Modified: 2010-12-12 22:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix typo (1.86 KB, patch)
2010-12-11 15:57 UTC, Emilio Pozuelo Monfort
none Details | Review
Use GLADE_CATALOG_DIR as used by configure.ac (1.20 KB, patch)
2010-12-12 22:50 UTC, Emilio Pozuelo Monfort
accepted-commit_now Details | Review

Description Emilio Pozuelo Monfort 2010-12-11 15:56:41 UTC
Hi,

There's a mismatch between configure.ac's GLADE_CATALOG_DIR and data/glade/Makefile.am's GLADE_CATALOGUE_DIR, resulting in the glade files not being installed in the right place.

The attached patch by Michael Terry fixes it by renaming GLADE_CATALOGUE_DIR to GLADE_CATALOG_DIR.
Comment 1 Emilio Pozuelo Monfort 2010-12-11 15:57:49 UTC
Created attachment 176239 [details] [review]
fix typo
Comment 2 jessevdk@gmail.com 2010-12-11 16:03:07 UTC
Review of attachment 176239 [details] [review]:

Could you provide a git format-patch? Also could you please rename the cataloguedir variable also to catalogdir (to make things more consistent). Thanks a lot!
Comment 3 Emilio Pozuelo Monfort 2010-12-12 22:50:41 UTC
Created attachment 176313 [details] [review]
Use GLADE_CATALOG_DIR as used by configure.ac

Done. OK to push?
Comment 4 Ignacio Casal Quinteiro (nacho) 2010-12-12 22:51:49 UTC
Review of attachment 176313 [details] [review]:

Go for it.
Comment 5 Emilio Pozuelo Monfort 2010-12-12 22:54:18 UTC
Thanks, pushed to master.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.