After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636964 - Don't use symbolic icons in sidebar?
Don't use symbolic icons in sidebar?
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-12-10 14:25 UTC by Bastien Nocera
Modified: 2011-01-27 17:45 UTC
See Also:
GNOME target: 3.0
GNOME version: ---


Attachments
playlist: Use toolbar instead of button bar (16.96 KB, patch)
2011-01-27 17:17 UTC, Bastien Nocera
committed Details | Review
using a button bar (old) (59.75 KB, image/png)
2011-01-27 17:18 UTC, Bastien Nocera
  Details
using a toolbar (new) (59.82 KB, image/png)
2011-01-27 17:19 UTC, Bastien Nocera
  Details

Description Bastien Nocera 2010-12-10 14:25:50 UTC
We're missing +, - and save.
Comment 1 Jakub Steiner 2011-01-18 15:48:33 UTC
list-add and list-remove as well as document-save are in gnome-icon-theme-symbolic. 

But unless you are exposing this in fullscreen mode, I don't think you need symbolic icons. For the sidebar, the full color icons serve the same purpose as toolbar icons. They don't need to be toned down.

http://live.gnome.org/UsabilityProject/HIG3/EditableLists
http://live.gnome.org/GnomeShell/Design/Whiteboards/SymbolicIcons/UseGuidelines
Comment 2 Bastien Nocera 2011-01-19 14:17:04 UTC
The problem isn't the toning down, the problem is that when a dark theme is used, the "colour" versions of the icons might not match the expected look/colour of the rest of the interface.

The symbolic icons look great btw. Thanks!
Comment 3 Jakub Steiner 2011-01-19 14:31:02 UTC
Can you give a specific example? We test the tango styled icons on dark background, they should work. They do tend to grab more attention but should be appropriate for the dark theme as well...
Comment 4 Bastien Nocera 2011-01-19 14:47:55 UTC
(In reply to comment #3)
> Can you give a specific example? We test the tango styled icons on dark
> background, they should work. They do tend to grab more attention but should be
> appropriate for the dark theme as well...

Not really, as we still don't have a dark theme variant for Adwaita. As soon as we have a dark variant, I'll re-test whether we should be using symbolic icons or not for the sidebar.
Comment 5 Bastien Nocera 2011-01-27 17:17:05 UTC
Created attachment 179447 [details] [review]
playlist: Use toolbar instead of button bar

This means less glade garbage, and using symbolic icons.
Comment 6 Bastien Nocera 2011-01-27 17:18:47 UTC
Created attachment 179448 [details]
using a button bar (old)
Comment 7 Bastien Nocera 2011-01-27 17:19:10 UTC
Created attachment 179449 [details]
using a toolbar (new)
Comment 8 Bastien Nocera 2011-01-27 17:45:35 UTC
As discussed on IRC, those toolbars are contextual action buttons,
not "proper" toolbars. The icons here replace what should have been
text (but wasn't in Totem).

Attachment 179447 [details] pushed as 8bc05fa - playlist: Use toolbar instead of button bar