After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 636928 - Fix mis-paired calls to JS_AddRoot/JS_RemoveRoot
Fix mis-paired calls to JS_AddRoot/JS_RemoveRoot
Status: RESOLVED FIXED
Product: gjs
Classification: Bindings
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gjs-maint
gjs-maint
Depends on:
Blocks:
 
 
Reported: 2010-12-09 23:03 UTC by Owen Taylor
Modified: 2010-12-10 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix mis-paired calls to JS_AddRoot/JS_RemoveRoot (1.34 KB, patch)
2010-12-09 23:03 UTC, Owen Taylor 		accepted-commit_now Details | Review

Description Owen Taylor 2010-12-09 23:03:37 UTC 
Fix a case where we would never remove a root we added and another
place where we removed a root twice in a cleanup path.
Comment 1 Owen Taylor 2010-12-09 23:03:39 UTC 
Created attachment 176158 [details] [review]
Fix mis-paired calls to JS_AddRoot/JS_RemoveRoot
Comment 2 Colin Walters 2010-12-10 15:07:53 UTC 
Review of attachment 176158 [details] [review]:

Both of these look good.