GNOME Bugzilla – Bug 636890
Build fails with recent GTK+; stop using deprecated API
Last modified: 2011-03-09 21:41:53 UTC
xutils.c: In function 'my_wnck_atom_get': xutils.c:43:29: error: 'gdk_display' undeclared (first use in this function) xutils.c:43:29: note: each undeclared identifier is reported only once for each function it appears in xutils.c: In function 'my_wnck_change_state': xutils.c:79:25: error: 'gdk_display' undeclared (first use in this function) xutils.c: In function 'my_wnck_error_trap_pop': xutils.c:103:10: error: 'gdk_display' undeclared (first use in this function) xutils.c: In function 'my_wnck_get_string_property_latin1': xutils.c:125:32: error: 'gdk_display' undeclared (first use in this function) xutils.c: In function 'my_wnck_window_get_xscreen': xutils.c:182:25: error: 'gdk_display' undeclared (first use in this function) xutils.c: In function 'my_wnck_get_cardinal_list': xutils.c:205:32: error: 'gdk_display' undeclared (first use in this function) xutils.c: In function 'my_wnck_get_cardinal': xutils.c:245:32: error: 'gdk_display' undeclared (first use in this function) make[2]: *** [xutils.o] Error 1 make[2]: *** Waiting for unfinished jobs.... That's just because GDK_DISABLE_DEPRECATED is used by default.
Created attachment 176750 [details] [review] Proposed patch #1 Patch replacing gdk_display with GDK_DISPLAY_XDISPLAY (gdk_display_get_default ()).
Confirmed when using GTK+ 2.22.1.
Confirmed on Fedora 15 and the patch attached to this bug report fixes it.
Confirmed on Fedora 14 also. libwnck-devel-2.30.4-1.fc14.i686 gtk2-2.22.0-1.fc14.1.i686
I'd already fixed this in git like this: - XMoveResizeWindow (gdk_display, + XMoveResizeWindow (gdk_x11_get_default_xdisplay (), Really need to make a release... maybe later today if I can get connectivity that doesn't take five minutes per page load.