GNOME Bugzilla – Bug 636869
confusing 'flickr' option
Last modified: 2014-02-13 14:57:58 UTC
I have this 'Flickr' option in the side bar of the panel, which just shows an empty bar, and is confusing me. I think we need to either - hide the flickr option unless an account is set up or - explain how to set one up in the empty area
I think it might be a libsocialweb bug, as I can't seem to get it to show anything, even though I have an account setup.
OK. It's actually normal when there's no account setup, or you don't have contacts in flickr, or your contacts didn't upload anything. We'd need to add a search entry at the top of the scrolled view, and do something like: diff --git a/panels/background/bg-flickr-source.c b/panels/background/bg-flickr-source.c index 2e164e6..e34fee3 100644 --- a/panels/background/bg-flickr-source.c +++ b/panels/background/bg-flickr-source.c @@ -145,14 +145,17 @@ bg_flickr_source_init (BgFlickrSource *self) { GnomeDesktopThumbnailFactory *thumb_factory; BgFlickrSourcePrivate *priv; + GHashTable *params; priv = self->priv = FLICKR_SOURCE_PRIVATE (self); priv->client = sw_client_new (); priv->service = sw_client_get_service (priv->client, "flickr"); + params = g_hash_table_new (g_str_hash, g_str_equal); + g_hash_table_insert (params, "text", "My search term"); sw_client_service_query_open_view (priv->service, - "feed", - NULL, + "x-flickr-search", + params, _query_open_view_cb, self); + g_hash_table_unref (params); Where "My search term" would be the search term entered in the search entry. This would be matching the mockups at: http://live.gnome.org/Design/SystemSettings/Background
As discussed on IRC, we'll probably want to use the user's photo streams instead of implementing a search, which would mean removing that search.
Removing GNOME Target as per IRC discussion with hadess on #gnome-hackers. You can use Target Milestones for project specific planning (you can set them up yourself if you are listed as module maintainer in Bugzilla).
How does this "Flickr" tab is supposed to work ? I just discovered this with the upgrade to GNOME 3.6, and it just shows me a blank space. Terminal gives me those error messages : ** (gnome-control-center:3617): WARNING **: sw-client-service.c:917: Error calling OpenView on service flickr: Method "OpenView" with signature "sa{ss}" on interface "com.meego.libsocialweb.Query" doesn't exist (gnome-control-center:3617): background-cc-panel-WARNING **: Could not connect to Flickr service Where am I supposed to configure this ? I guess the background picker should tell me about that, when I'm clicking on the "Flickr" tab for the first time.
You are probably using Ubuntu - they heavily patch the control-center, including this. There's no flickr support in the upstream background panel at this point afaik.
(In reply to comment #6) > You are probably using Ubuntu - they heavily patch the control-center, > including this. There's no flickr support in the upstream background panel at > this point afaik. It's there if you compile with libsocialweb.
(In reply to comment #6) > You are probably using Ubuntu - they heavily patch the control-center, > including this. There's no flickr support in the upstream background panel at > this point afaik. Actually, I'm using Arch Linux. I also have libsocialweb already installed.
(In reply to comment #7) > > It's there if you compile with libsocialweb. I had no idea !
The good solution (R) would be to make gnome-online-accounts have a flickr account (#678151), right? But if that takes long for whichever reason, it would be nice to either hide it completely if the libsocialweb does not have a flickr account, or as suggested in the description it tells the user how to make this tab display some images to choose.
(In reply to comment #10) > The good solution (R) would be to make gnome-online-accounts have a flickr > account (#678151), right? And have libsocialweb use it too. > But if that takes long for whichever reason, it would be nice to either hide it > completely if the libsocialweb does not have a flickr account, or as suggested > in the description it tells the user how to make this tab display some images > to choose. The default is to disable libsocialweb, so unless it's explicitely enabled, the user won't see the tab. I think that's good enough until we have the 2 problems mentioned above fixed.
We are replacing libsocialweb with Grilo, which also supports Flickr and integrates with GOA. *** This bug has been marked as a duplicate of bug 707569 ***